From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: Always flush tiling changes before accessing through the GTT
Date: Wed, 18 Apr 2012 10:48:53 +0200 [thread overview]
Message-ID: <20120418084853.GD5315@phenom.ffwll.local> (raw)
In-Reply-To: <20120414220035.GD4215@phenom.ffwll.local>
On Sun, Apr 15, 2012 at 12:00:35AM +0200, Daniel Vetter wrote:
> On Sat, Apr 14, 2012 at 09:55:51AM +0100, Chris Wilson wrote:
> > As we defer updating the fence register from set-tiling to the point of
> > use, we need to declare every access through the GTT as either fenced or
> > unfenced.
> >
> > This patches fixes an old bug in the execbuffer relocation processing
> > which could conceivably be hit by a pathological userspace.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Indeed, my git history digging got lost and given how we upload buffers I
> don't think there's any chance we can hit this, so no i-g-t test
> necessary.
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-18 8:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 8:55 [PATCH 1/5] drm/i915: Suppress EIO during set-to-gtt Chris Wilson
2012-04-14 8:55 ` [PATCH 2/5] drm/i915: Suppress EIO through fence-flushing Chris Wilson
2012-04-14 9:02 ` Chris Wilson
2012-04-14 8:55 ` [PATCH 3/5] drm/i915: Suppress EIO during i915_gem_idle() Chris Wilson
2012-04-18 8:51 ` Daniel Vetter
2012-04-18 9:03 ` Chris Wilson
2012-04-14 8:55 ` [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT Chris Wilson
2012-04-14 21:54 ` Daniel Vetter
2012-04-14 21:59 ` Chris Wilson
2012-04-14 8:55 ` [PATCH 5/5] " Chris Wilson
2012-04-14 22:00 ` Daniel Vetter
2012-04-18 8:48 ` Daniel Vetter [this message]
2012-04-14 9:02 ` [PATCH 1/5] drm/i915: Suppress EIO during set-to-gtt Chris Wilson
2012-04-18 9:03 ` Daniel Vetter
2012-04-18 9:10 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418084853.GD5315@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.