From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/6] mmc: sh_mmcif: do not manage PM clocks manually
Date: Wed, 18 Apr 2012 12:01:07 +0000 [thread overview]
Message-ID: <20120418120106.GA22189@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1204181323290.30514@axis700.grange>
On Wed, Apr 18, 2012 at 01:28:32PM +0200, Guennadi Liakhovetski wrote:
> On sh-mobile platforms the MMC clock frequency for the MMCIF unit is
> obtained from the same clock, as the one, that runtime power-manages the
> controller. The MMCIF driver has to access that clock directly,
> bypassing the runtime PM framework, to get its frequency, but it
> shouldn't enable or disable it.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
I don't understand your logic. clk_get_rate() requires the clock to be
enabled, the result is undefined otherwise. If you have a case where the
clock is already enabled and you can read the rate directly that's fine,
but it's still an API violation without enable/disable pairs.
next prev parent reply other threads:[~2012-04-18 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 11:28 [PATCH 2/6] mmc: sh_mmcif: do not manage PM clocks manually Guennadi Liakhovetski
2012-04-18 12:01 ` Paul Mundt [this message]
2012-04-18 12:36 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418120106.GA22189@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.