From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
Date: Wed, 18 Apr 2012 14:23:27 +0200 [thread overview]
Message-ID: <201204181423.27914.marex@denx.de> (raw)
In-Reply-To: <4F8E9CD2.1060307@de.bosch.com>
Dear Dirk Behme,
> On 31.03.2012 20:35, Marek Vasut wrote:
> > Dear Dirk Behme,
> >
> >> Fix the warning
> >>
> >> mmc.c: In function 'mmc_send_cmd':
> >> mmc.c:87: warning: assignment from incompatible pointer type
> >>
> >> in case CONFIG_MMC_TRACE is enabled.
> >>
> >> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> >> CC: Andy Fleming <afleming@freescale.com>
I'd be glad to see it in ... Andy?
> >> ---
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > Acked-by: Simon Glass <sjg@chromium.org>
> >
> >> drivers/mmc/mmc.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> >> index 21665ec..881b5c0 100644
> >> --- a/drivers/mmc/mmc.c
> >> +++ b/drivers/mmc/mmc.c
> >> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> >> struct mmc_data *data) for (i = 0; i < 4; i++) {
> >>
> >> int j;
> >> printf("\t\t\t\t\t%03d - ", i*4);
> >>
> >> - ptr = &cmd->response[i];
> >> + ptr = (u8 *)&cmd->response[i];
> >>
> >> ptr += 3;
> >> for (j = 0; j < 4; j++)
> >>
> >> printf("%02X ", *ptr--);
>
> Who could help to still get this into 2012.04?
>
> Many thanks,
>
> Dirk
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-18 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 12:35 [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled Dirk Behme
2012-03-31 8:12 ` Simon Glass
2012-03-31 18:35 ` Marek Vasut
2012-04-18 10:52 ` Dirk Behme
2012-04-18 12:23 ` Marek Vasut [this message]
2012-04-21 15:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204181423.27914.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.