From: Matthew Garrett <mjg@redhat.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Bastien Nocera <hadess@hadess.net>, Jiri Kosina <jkosina@suse.cz>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fedoraproject.org,
Richard Hughes <richard@hughsie.com>
Subject: Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no
Date: Wed, 18 Apr 2012 15:24:50 +0100 [thread overview]
Message-ID: <20120418142450.GA30083@srcf.ucam.org> (raw)
In-Reply-To: <20120418141131.GN19507@zod.bos.redhat.com>
On Wed, Apr 18, 2012 at 10:11:31AM -0400, Josh Boyer wrote:
> On Wed, Apr 18, 2012 at 03:08:54PM +0100, Bastien Nocera wrote:
> > Don't. The only bit of user-space that's broken is upower, and it's
> > getting a fixed release shortly.
>
> Matthew suggested that additional kernel patches were required to add a
> scope parameter so upower could understand that the battery is powering
> a device and not the system.
>
> Also, when did it become OK to force-enable a new feature that is
> _known_ to not work properly on recent userspace? That makes no sense
> to me.
I agree. It's a great feature, but it shouldn't be default y if
userspace isn't ready for it yet.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-04-18 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 14:05 [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no Josh Boyer
2012-04-18 14:08 ` Bastien Nocera
2012-04-18 14:11 ` Josh Boyer
2012-04-18 14:24 ` Matthew Garrett [this message]
2012-04-18 17:12 ` Jeremy Fitzhardinge
2012-04-18 17:20 ` Matthew Garrett
2012-04-18 17:28 ` Jiri Kosina
2012-04-22 8:38 ` Geert Uytterhoeven
2012-04-22 8:38 ` Geert Uytterhoeven
2012-04-24 8:52 ` Jiri Kosina
2012-04-24 8:52 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418142450.GA30083@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=hadess@hadess.net \
--cc=jeremy@goop.org \
--cc=jkosina@suse.cz \
--cc=jwboyer@redhat.com \
--cc=kernel-team@fedoraproject.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@hughsie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.