All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 04/10] xfs: implement freezing by emptying the AIL
Date: Wed, 18 Apr 2012 13:14:07 -0500	[thread overview]
Message-ID: <20120418181407.GC16881@sgi.com> (raw)
In-Reply-To: <4F8EBE13.9040207@sgi.com>

On Wed, Apr 18, 2012 at 08:13:55AM -0500, Mark Tinguely wrote:
> On 04/17/12 03:26, Dave Chinner wrote:
> >On Tue, Apr 17, 2012 at 02:20:23PM +1000, Dave Chinner wrote:
> >
> >commit 281627df3eb55e1b729b9bb06fff5ff112929646
> >Author: Christoph Hellwig<hch@infradead.org>
> >Date:   Tue Mar 13 08:41:05 2012 +0000
> >
> >     xfs: log file size updates at I/O completion time
> >
> >That confirms my analysis above - the problem is being exposed by new
> >code in the writeback path that does transaction allocation where it
> >didn't used to.
> >
> >Clearly the problem is not really the new code in Christoph's
> >patches - it's an existing freeze problem that has previously
> >resulted in data writes occuring after a freeze has completed (of
> >which we have had rare complaints about). That sounds pretty dire,
> >except for one thing: Jan Kara's patch set that fixes all these
> >freeze problems:
> >
> >https://lkml.org/lkml/2012/4/16/356
> >
> >And now that I've run some testing with Jan's patch series, along
> >with Christoph's and mine (75-odd patches ;), a couple of my test
> >VMs have been running test 068 in a tight loop for about half an
> >hour without a hang, so I'd consider this problem fixed by Jan's
> >freeze fixes given I could reliably hang it in 2-3 minutes before
> >adding Jan's patch set to my stack.
> >
> >So the fix for this problem is getting Jan's patch set into the
> >kernel at the same time we get the inode size logging changes into
> >the kernel. What do people think about that for a plan?
> >
> >Cheers,
> >
> >Dave.
> 
> Good job.
> 
> Jan's freeze patch set is at v5 and seems to be settling down. What
> is the status of Jan's freeze code getting into the kernel?

The trouble I was having yesterday seems to be related to the i386 box on which
I was running.  Apparently something has regressed badly since 3.3 on that
i386.  Seems to be working fine on another x86_64 machine.

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-04-18 18:18 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 16:44 [PATCH 00/10] remove xfsbufd Christoph Hellwig
2012-03-27 16:44 ` [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown Christoph Hellwig
2012-03-27 18:17   ` Mark Tinguely
2012-04-13  9:36   ` Dave Chinner
2012-03-27 16:44 ` [PATCH 02/10] xfs: remove log item from AIL in xfs_iflush " Christoph Hellwig
2012-04-13  9:37   ` Dave Chinner
2012-03-27 16:44 ` [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held Christoph Hellwig
2012-03-27 18:18   ` Mark Tinguely
2012-04-13  9:42   ` Dave Chinner
2012-03-27 16:44 ` [PATCH 04/10] xfs: implement freezing by emptying the AIL Christoph Hellwig
2012-04-13 10:04   ` Dave Chinner
2012-04-16 13:33   ` Mark Tinguely
2012-04-16 13:47   ` Mark Tinguely
2012-04-16 23:54     ` Dave Chinner
2012-04-17  4:20       ` Dave Chinner
2012-04-17  8:26         ` Dave Chinner
2012-04-18 13:13           ` Mark Tinguely
2012-04-18 18:14             ` Ben Myers [this message]
2012-04-18 17:53           ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 05/10] xfs: do flush inodes from background inode reclaim Christoph Hellwig
2012-04-13 10:14   ` Dave Chinner
2012-04-16 19:25   ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 06/10] xfs: do not write the buffer from xfs_iflush Christoph Hellwig
2012-04-13 10:31   ` Dave Chinner
2012-04-18 13:33   ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush Christoph Hellwig
2012-04-13 10:33   ` Dave Chinner
2012-04-18 21:11   ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed Christoph Hellwig
2012-04-13 10:35   ` Dave Chinner
2012-04-18 21:11   ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 09/10] xfs: on-stack delayed write buffer lists Christoph Hellwig
2012-04-13 11:37   ` Dave Chinner
2012-04-20 18:19   ` Mark Tinguely
2012-04-21  0:42     ` Dave Chinner
2012-04-23  1:57       ` Dave Chinner
2012-03-27 16:44 ` [PATCH 10/10] xfs: remove some obsolete comments in xfs_trans_ail.c Christoph Hellwig
2012-04-13 11:37   ` Dave Chinner
2012-03-28  0:53 ` [PATCH 00/10] remove xfsbufd Dave Chinner
2012-03-28 15:10   ` Christoph Hellwig
2012-03-29  0:52     ` Dave Chinner
2012-03-29 19:38       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418181407.GC16881@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.