From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC PATCH] drm: Add plane event Date: Wed, 18 Apr 2012 21:19:42 +0300 Message-ID: <20120418181942.GT4917@intel.com> References: <1334723519-32141-1-git-send-email-jy0922.shim@samsung.com> <20120418084634.GC5315@phenom.ffwll.local> <4F8E9361.3080004@samsung.com> <4F8ECA08.2080601@stericsson.com> <20120418142607.GR4917@intel.com> <20120418143659.GB20469@phenom.ffwll.local> <4F8ED977.9090706@stericsson.com> <20120418152757.GD20469@phenom.ffwll.local> <20120418160610.GS4917@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 6FF0A9E778 for ; Wed, 18 Apr 2012 11:19:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120418160610.GS4917@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: "hoegsberg@gmail.com" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Wed, Apr 18, 2012 at 07:06:10PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Apr 18, 2012 at 05:27:57PM +0200, Daniel Vetter wrote: > > Also, I'm toying around with ideas to split up the big modeset lock such > > that operations that only touch the crtc (like pageflip, plane changes = and > > cursor changes) do not take the big modeset lock but only a per-crtc > > mutex. > = > Plane operations might well involve multiple CRTCs (when moving the > planes between pipes for example). You have to be careful with the > locking order when doing stuff like that. One option would be to > always take the per-CRTC locks in the same order (based on the > object ID for example). Multiple locks will also cause problems for the atomic mode set. The full device state may be needed to evaluate whether a certain change is allowed, which means any change happening in parallel can screw things up. -- = Ville Syrj=E4l=E4 Intel OTC