All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Peter Huang (Peng)" <peter.huangpeng@huawei.com>
Cc: shemminger@vyatta.com, "'David S. Miller'" <davem@davemloft.net>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com,
	linux-kernel@vger.kernel.org, ctrix+debianbugs@navynet.it,
	peter.huangpeng@gmail.com, harry.majun@huawei.com
Subject: Re: [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops.
Date: Wed, 18 Apr 2012 14:04:50 -0500	[thread overview]
Message-ID: <20120418190450.GA30185@burratino> (raw)
In-Reply-To: <000001cd1c62$75d10de0$617329a0$%huangpeng@huawei.com>

Hi,

Peter Huang (Peng) wrote:

> When bridge is deleted before tap/vif device's delete, kernel may
> encounter an oops because of NULL reference to fake_rtable's dst.
>
> Set fake_rtable's dst to NULL before sending packets out can solve
> this problem.
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Peter Huang <peter.huangpeng@huawei.com>
> ---
> include/linux/netfilter_bridge.h |    8 ++++++++
>  net/bridge/br_forward.c          |    1 +
>  net/bridge/br_netfilter.c        |    6 +-----
>  3 files changed, 10 insertions(+), 5 deletions(-)

Massimo Cetra (cc-ed) tested the patch against a 3.2.y kernel and wrote[1]:

> The patch i applied yesterday to the debian kernel has been installed 
> and the kernel is not panic-ing anymore.
>
> I'll try to keep this bug up to date.

So it seems to work.  Dave, please consider queuing this for stable@
when the final patch is ready.

Thanks,
Jonathan

[1] http://bugs.debian.org/668511#37

  parent reply	other threads:[~2012-04-18 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  6:22 [PATCH] set fake_rtable's dst to NULL to avoid kernel Oops Peter Huang (Peng)
2012-04-17 15:52 ` Stephen Hemminger
2012-04-17 16:48   ` Eric Dumazet
2012-04-18  7:57     ` Peter Huang(Peng)
2012-04-18  8:23       ` Eric Dumazet
2012-04-18  8:41       ` David Miller
2012-04-18 19:04 ` Jonathan Nieder [this message]
2012-04-19  7:58   ` Massimo Cetra
  -- strict thread matches above, loose matches on Subject: below --
2012-03-29  6:21 Peter Huang (Peng)
2012-03-29  6:36 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418190450.GA30185@burratino \
    --to=jrnieder@gmail.com \
    --cc=ctrix+debianbugs@navynet.it \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=harry.majun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.huangpeng@gmail.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.