From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f42.google.com (mail-pz0-f42.google.com [209.85.210.42]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 01CA3B6FEB for ; Fri, 20 Apr 2012 01:29:00 +1000 (EST) Received: by dang27 with SMTP id g27so12768925dan.15 for ; Thu, 19 Apr 2012 08:28:57 -0700 (PDT) Date: Thu, 19 Apr 2012 08:28:51 -0700 From: Greg K H To: Mauro Carvalho Chehab Subject: Re: [PATCH] edac: change the mem allocation scheme to make Documentation/kobject.txt happy Message-ID: <20120419152851.GD31543@kroah.com> References: <1334697467.3920.5.camel@joe2Laptop> <1334841690-305-1-git-send-email-mchehab@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1334841690-305-1-git-send-email-mchehab@redhat.com> Cc: "Arvind R." , Michal Marek , linuxppc-dev@lists.ozlabs.org, Mark Gross , Shaohui Xie , Dmitry Eremin-Solenikov , Jiri Kosina , Ranganathan Desikan , Borislav Petkov , Chris Metcalf , Linux Kernel Mailing List , Egor Martovetsky , Aristeu Rozanski , Olof Johansson , Doug Thompson , Andrew Morton , Tim Small , Hitoshi Mitake , Linux Edac Mailing List List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 19, 2012 at 10:21:30AM -0300, Mauro Carvalho Chehab wrote: > Kernel kobjects have rigid rules: each container object should be > dynamically allocated, and can't be allocated into a single kmalloc. > > EDAC never obeyed this rule: it has a single malloc function that > allocates all needed data into a single kzalloc. > > As this is not accepted anymore, change the allocation schema of the > EDAC *_info structs to enforce this Kernel standard. Very nice work, thanks for doing this: Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755626Ab2DSP3A (ORCPT ); Thu, 19 Apr 2012 11:29:00 -0400 Received: from mail-pz0-f52.google.com ([209.85.210.52]:49188 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755573Ab2DSP26 (ORCPT ); Thu, 19 Apr 2012 11:28:58 -0400 Date: Thu, 19 Apr 2012 08:28:51 -0700 From: Greg K H To: Mauro Carvalho Chehab Cc: Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Borislav Petkov , Mark Gross , Tim Small , Ranganathan Desikan , "Arvind R." , Olof Johansson , Egor Martovetsky , Chris Metcalf , Michal Marek , Jiri Kosina , Dmitry Eremin-Solenikov , Benjamin Herrenschmidt , Hitoshi Mitake , Andrew Morton , Shaohui Xie , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] edac: change the mem allocation scheme to make Documentation/kobject.txt happy Message-ID: <20120419152851.GD31543@kroah.com> References: <1334697467.3920.5.camel@joe2Laptop> <1334841690-305-1-git-send-email-mchehab@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334841690-305-1-git-send-email-mchehab@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2012 at 10:21:30AM -0300, Mauro Carvalho Chehab wrote: > Kernel kobjects have rigid rules: each container object should be > dynamically allocated, and can't be allocated into a single kmalloc. > > EDAC never obeyed this rule: it has a single malloc function that > allocates all needed data into a single kzalloc. > > As this is not accepted anymore, change the allocation schema of the > EDAC *_info structs to enforce this Kernel standard. Very nice work, thanks for doing this: Acked-by: Greg Kroah-Hartman