All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: xen/p2m: m2p_find_override: use list_for_each_entry_safe
Date: Fri, 20 Apr 2012 13:51:12 +0300	[thread overview]
Message-ID: <20120420105112.GA21487@elgon.mountain> (raw)

Hi Stefano,

I had a question about 8f2854c74ff4: "xen/p2m: m2p_find_override: use
list_for_each_entry_safe".

I think there is a misunderstanding about what the
list_for_each_entry_safe() macro does.  It has nothing to do with
locking, so the spinlock is still needed.  Without the lock ->next could
point to an element which has been deleted in another thread.  Probably
the patch should be reverted.

Also, it introduces a GCC warning:
arch/x86/xen/p2m.c:811:16: warning: unused variable ‘flags’
	[-Wunused-variable]

regards,
dan carpenter


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2012-04-20 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 10:51 Dan Carpenter [this message]
2012-04-20 11:23 ` xen/p2m: m2p_find_override: use list_for_each_entry_safe Stefano Stabellini
2012-04-20 11:35   ` Dan Carpenter
2012-04-20 13:36     ` Stefano Stabellini
2012-04-20 16:01       ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120420105112.GA21487@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.