From: Nick Piggin <npiggin@kernel.dk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
npiggin@kernel.dk
Subject: Re: [PATCH] dcache: faster dentry_cmp()
Date: Fri, 20 Apr 2012 22:06:54 +1000 [thread overview]
Message-ID: <20120420120654.GA26894@amd.local0.net> (raw)
In-Reply-To: <20120214224526.GA3478@p183.telecom.by>
On Wed, Feb 15, 2012 at 01:45:27AM +0300, Alexey Dobriyan wrote:
> 1) consistently use "unsigned int" for dentry name length,
> 2) reuse subtraction result for return value, exact value doesn't matter
> because function is only used in boolean context,
> 3) use *p++ idiom for even better code.
>
> All of this results in performance speedup of "git diff"
> which is way out of statistical error (0.4% vs 0.15% of 3 sigma):
Would you have any interest to port this patch on top of
Linus' latest changes there? 0.4% increase is nothing to
sneeze at. There may be some improvements with the
DCACHE_WORD_ACCESS code too.
prev parent reply other threads:[~2012-04-20 12:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 22:45 [PATCH] dcache: faster dentry_cmp() Alexey Dobriyan
2012-02-14 22:58 ` Al Viro
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:41 ` Matthew Wilcox
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:46 ` Andi Kleen
2012-02-15 8:16 ` Alexey Dobriyan
2012-02-15 11:19 ` Alexey Dobriyan
2012-02-15 20:20 ` Andi Kleen
2012-04-20 12:06 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420120654.GA26894@amd.local0.net \
--to=npiggin@kernel.dk \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.