From: Josef Bacik <josef@redhat.com>
To: Jim Meyering <jim@meyering.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 4/4] mkfs: avoid heap-buffer-read-underrun for zero-length "size" arg
Date: Fri, 20 Apr 2012 14:41:28 -0400 [thread overview]
Message-ID: <20120420184128.GD1957@localhost.localdomain> (raw)
In-Reply-To: <1334943408-6720-5-git-send-email-jim@meyering.net>
On Fri, Apr 20, 2012 at 07:36:48PM +0200, Jim Meyering wrote:
> From: Jim Meyering <meyering@redhat.com>
>
> * mkfs.c (parse_size): ./mkfs.btrfs -A '' would read and possibly
> write the byte before beginning of strdup'd heap buffer. All other
> size-accepting options were similarly affected.
> ---
> mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs.c b/mkfs.c
> index 03239fb..4aff2fd 100644
> --- a/mkfs.c
> +++ b/mkfs.c
> @@ -63,7 +63,7 @@ static u64 parse_size(char *s)
>
> s = strdup(s);
>
> - if (!isdigit(s[len - 1])) {
> + if (len && !isdigit(s[len - 1])) {
> c = tolower(s[len - 1]);
> switch (c) {
> case 'g':
Reviewed-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
prev parent reply other threads:[~2012-04-20 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 17:36 btrfs-utils: minor buffer-overrun fixes Jim Meyering
2012-04-20 17:36 ` [PATCH 1/4] mkfs: use strdup in place of strlen,malloc,strcpy sequence Jim Meyering
2012-04-20 18:36 ` Josef Bacik
2012-04-20 17:36 ` [PATCH 2/4] restore: don't corrupt stack for a zero-length command-line argument Jim Meyering
2012-04-20 18:37 ` Josef Bacik
2012-04-20 18:40 ` Josef Bacik
2012-04-20 17:36 ` [PATCH 3/4] avoid strncpy-induced buffer overrun Jim Meyering
2012-04-20 18:42 ` Josef Bacik
2012-04-20 19:26 ` Jim Meyering
2012-04-20 17:36 ` [PATCH 4/4] mkfs: avoid heap-buffer-read-underrun for zero-length "size" arg Jim Meyering
2012-04-20 18:41 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420184128.GD1957@localhost.localdomain \
--to=josef@redhat.com \
--cc=jim@meyering.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.