From: Clemens Buchacher <drizzd@aon.at>
To: Pete Wyckoff <pw@padd.com>
Cc: Stefano Lattarini <stefano.lattarini@gmail.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-remote-testgit: fix race when spawning fast-import
Date: Sun, 22 Apr 2012 01:42:12 +0200 [thread overview]
Message-ID: <20120421234211.GC20473@ecki> (raw)
In-Reply-To: <20120421234555.GA11808@padd.com>
On Sat, Apr 21, 2012 at 07:45:55PM -0400, Pete Wyckoff wrote:
>
> @@ -258,6 +264,7 @@ def main(args):
>
> more = True
>
> + sys.stdin = os.fdopen(sys.stdin.fileno(), 'r', 0)
> while (more):
> more = read_one_line(repo)
There's another read in do_import(). I am not sure if it also suffers
from this race condition, but it certainly has the potential.
> +test_expect_success 'racily pushing to local repo' '
> + cp -a server server2 &&
> + git clone "testgit::${PWD}/server2" localclone2 &&
> + test_when_finished "rm -rf server2 localclone2" &&
> + (cd localclone2 &&
> + echo content >>file &&
> + git commit -a -m three &&
> + GIT_REMOTE_TESTGIT_SLEEPY=2 git push) &&
> + compare_refs localclone2 HEAD server2 HEAD
> +'
Should this test be running unconditionally? It will delay the otherwise
almost instant test by 2 seconds.
next prev parent reply other threads:[~2012-04-22 0:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 9:01 master: t5800-remote-helpers.sh hangs on test "pulling from remote remote" Stefano Lattarini
2012-04-14 20:14 ` Clemens Buchacher
2012-04-15 0:00 ` Stefano Lattarini
2012-04-15 1:11 ` Clemens Buchacher
2012-04-15 8:08 ` Stefano Lattarini
2012-04-15 10:59 ` Clemens Buchacher
2012-04-15 11:18 ` Stefano Lattarini
2012-04-15 11:45 ` Clemens Buchacher
2012-04-15 11:58 ` Stefano Lattarini
2012-04-15 12:09 ` Clemens Buchacher
2012-04-15 13:19 ` Stefano Lattarini
2012-04-15 12:51 ` Clemens Buchacher
2012-04-17 1:46 ` Sverre Rabbelier
2012-04-19 23:34 ` Pete Wyckoff
[not found] ` <4F9145A1.6020201@gmail.com>
2012-04-21 20:15 ` Pete Wyckoff
2012-04-21 23:35 ` Clemens Buchacher
2012-04-22 2:17 ` Pete Wyckoff
2012-04-21 23:45 ` [PATCH] git-remote-testgit: fix race when spawning fast-import Pete Wyckoff
2012-04-21 23:42 ` Clemens Buchacher [this message]
2012-04-22 2:16 ` Pete Wyckoff
2012-04-22 9:49 ` Clemens Buchacher
2012-04-22 4:50 ` Junio C Hamano
2012-04-22 20:30 ` [PATCHv2] " Pete Wyckoff
2012-04-23 2:40 ` Junio C Hamano
2012-04-23 11:35 ` Pete Wyckoff
2012-04-15 11:12 ` master: t5800-remote-helpers.sh hangs on test "pulling from remote remote" Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120421234211.GC20473@ecki \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
--cc=srabbelier@gmail.com \
--cc=stefano.lattarini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.