From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org,
Mattias Wallin <mattias.wallin@stericsson.com>,
Jonas Aberg <jonas.aberg@stericsson.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] regulator: core: Keep boot_on regulators powered during init
Date: Mon, 23 Apr 2012 11:18:05 +0100 [thread overview]
Message-ID: <20120423101804.GA8318@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1335173873-24301-1-git-send-email-ulf.hansson@stericsson.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Mon, Apr 23, 2012 at 11:37:53AM +0200, Ulf Hansson wrote:
> Regulators which has boot_on constraints set, will now remain
> powered after regulator_init_complete is done.
This would be a bug. All boot_on means is that the regulator was turned
on during boot, the regulator is free to vary after that.
> In this case we leave the enable->disable operation to be
> handled by the regulator consumer instead.
Which would be a bug if the consumer wasn't the thing that took the
reference to the regulator in the first place. Remember, regulators can
be shared so the consumer can't disable a regulator it didn't enable in
the first place (unless it used regulator_get_exclusive() but the use
cases for that are a little suspicious so it'd be worth taking a careful
look before using it). A consumer can't tell if the regulator was left
enabled by the firmware on boot or if it has been enabled by another
consumer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-23 10:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:37 [PATCH] regulator: core: Keep boot_on regulators powered during init Ulf Hansson
2012-04-23 10:18 ` Mark Brown [this message]
2012-04-23 10:52 ` Ulf Hansson
2012-04-23 11:05 ` Mark Brown
2012-04-23 12:21 ` Ulf Hansson
2012-04-23 12:25 ` Mark Brown
2012-04-23 12:45 ` Ulf Hansson
2012-04-23 18:01 ` Mark Brown
2012-04-24 8:09 ` Ulf Hansson
2012-04-24 10:56 ` Mark Brown
2012-04-24 12:43 ` Ulf Hansson
2012-04-25 8:02 ` Mark Brown
2012-04-25 9:37 ` Ulf Hansson
2012-04-25 9:58 ` Mark Brown
2012-04-25 16:45 ` Jassi Brar
2012-04-25 15:34 ` Jassi Brar
2012-04-25 15:44 ` Ulf Hansson
2012-04-25 16:31 ` Jassi Brar
2012-04-26 8:35 ` Mark Brown
2012-04-26 9:10 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423101804.GA8318@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jonas.aberg@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mattias.wallin@stericsson.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.