From: Benjamin LaHaise <bcrl@kvack.org>
To: James Chapman <jchapman@katalix.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 00/10] l2tp: misc fixes and add L2TPv3 IP encap over IPv6
Date: Mon, 23 Apr 2012 09:06:35 -0400 [thread overview]
Message-ID: <20120423130635.GE768@kvack.org> (raw)
In-Reply-To: <4F951F13.9060301@katalix.com>
On Mon, Apr 23, 2012 at 10:21:23AM +0100, James Chapman wrote:
> Ok.
>
> Ben, if I can help with the loopback checksum issue, please let me know.
The fix is pretty simple; in l2tp_xmit_ipv6_csum, change CHECKSUM_COMPLETE
to CHECKSUM_UNNECESSARY (or CHECKSUM_NONE), as that will prevent the
incoming sk_buff's ->csum value from being used (it's not correct). I'm
travelling at the moment, so I may not have time to respin the patch until
Wednesday, but if I can, I will try to find the time this evening.
-ben
--
"Thought is the essence of where you are now."
prev parent reply other threads:[~2012-04-23 13:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:02 [PATCH 00/10] l2tp: misc fixes and add L2TPv3 IP encap over IPv6 James Chapman
2012-04-20 9:02 ` [PATCH 01/10] l2tp: fix locking of 64-bit counters for smp James Chapman
2012-04-20 9:02 ` [PATCH 02/10] l2tp: Use ip4_datagram_connect() in l2tp_ip_connect() James Chapman
2012-04-20 9:02 ` [PATCH 03/10] l2tp: remove unused stats from l2tp_ip socket James Chapman
2012-04-20 9:02 ` [PATCH 04/10] pppox: Replace __attribute__((packed)) in if_pppox.h James Chapman
2012-04-20 9:02 ` [PATCH 05/10] l2tp: pppol2tp_connect() handles ipv6 sockaddr variants James Chapman
2012-04-20 9:02 ` [PATCH 06/10] l2tp: show IPv6 addresses in l2tp debugfs file James Chapman
2012-04-20 9:02 ` [PATCH 07/10] l2tp: netlink api for l2tpv3 ipv6 unmanaged tunnels James Chapman
2012-04-20 9:02 ` [PATCH 08/10] ipv6: Export ipv6 functions for use by other protocols James Chapman
2012-04-20 9:02 ` [PATCH 09/10] l2tp: introduce L2TPv3 IP encapsulation support for IPv6 James Chapman
2012-04-20 9:02 ` [PATCH 10/10] l2tp: let iproute2 create L2TPv3 IP tunnels using IPv6 James Chapman
2012-04-22 4:29 ` [PATCH 00/10] l2tp: misc fixes and add L2TPv3 IP encap over IPv6 David Miller
2012-04-23 9:21 ` James Chapman
2012-04-23 13:06 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423130635.GE768@kvack.org \
--to=bcrl@kvack.org \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.