From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dieter Bloms Subject: Re: [Xen-users] xl doesn't honour the parameter cpu_weight from my config file while xm does honour it Date: Mon, 23 Apr 2012 17:41:13 +0200 Message-ID: <20120423154112.GA15320@bloms.de> References: <20120420150012.GB3720@bloms.de> <1334934791.28331.101.camel@zakaz.uk.xensource.com> <20120423094623.GA13565@bloms.de> <1335182682.4347.15.camel@zakaz.uk.xensource.com> <1335190962.3122.10.camel@Abyss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1335190962.3122.10.camel@Abyss> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: George Dunlap , Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org Hi, > Maybe weight is, but still, I think having some mechanism for specifying > the full set of parameter of a specific scheduler is to be preferred... > > > I wonder if perhaps including each of libxl_sched_*_params in build_info > > might be a preferable interface? I would probably cleanup the above code > > in build_pre too since you could just call the appropriate > > libxl_sched_*_params_set. > > > ... Exactly, that's much better looking to me. that's a good hint. > > Ideally libxl_sched_*_params would be in a union in > > libxl_domain_build_info but that would require that xl could easily > > determine which scheduler was going to be used for the domain, having a > > non-union here would keep things somewhat simpler from that PoV. > > > Yes, again, I agree that a union will be even better, but maybe not so > much a big deal for now (we can turn it into an union later, right? Or > you think there will be some API implications?) ok, I see the point and will change it to a union. I checked out the source with git not hg, may I produce a diff with git and send it via mail ? -- Best regards Dieter Bloms -- I do not get viruses because I do not use MS software. If you use Outlook then please do not put my email address in your address-book so that WHEN you get a virus it won't use my address in the >>From field.