From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Martin Peres <martin.peres@free.fr>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery
Date: Mon, 23 Apr 2012 19:33:19 +0200 [thread overview]
Message-ID: <20120423173319.GD2886@joi.lan> (raw)
In-Reply-To: <4F958771.6040008@free.fr>
On Mon, Apr 23, 2012 at 06:46:41PM +0200, Martin Peres wrote:
> Hey,
>
> Just a minor mistake spotted while skimming through the patch.
>
> Le 23/04/2012 00:18, Marcin Slusarz a écrit :
> > +static inline uint64_t nv_timeout(struct drm_device *dev)
> > +{
> > + uint64_t tm = 2000000000ULL;
> > + if (nouveau_gpu_reset_in_progress(dev))
> > + tm /= 40; /* 50ms */
> This will cause a problem on 32 bit kernels. You should use do_div.
>
Thanks. I'll fix this later.
Marcin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2012-04-23 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 22:18 [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery Marcin Slusarz
2012-04-23 8:43 ` Martin Peres
2012-04-23 16:32 ` Marcin Slusarz
[not found] ` <20120423163257.GA2886-OI9uyE9O0yo@public.gmane.org>
2012-04-23 16:56 ` Martin Peres
2012-04-24 19:31 ` Marcin Slusarz
[not found] ` <20120424193150.GC2857-OI9uyE9O0yo@public.gmane.org>
2012-04-25 0:32 ` Ben Skeggs
2012-04-25 11:06 ` [Nouveau] " Christoph Bumiller
2012-04-23 16:46 ` Martin Peres
2012-04-23 17:33 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423173319.GD2886@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=martin.peres@free.fr \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.