Re: [PATCH 2/8] ASoC: core: Add strobe control

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]

On Fri, Apr 20, 2012 at 11:32:44AM +0200, Ola Lilja wrote:
> From: Kristoffer KARLSSON <kristoffer.karlsson@stericsson.com>
> 
> Added support for a control that strobes a bit in
> a register to high then back to low (or the inverse).

I've applied this but...

> +	unsigned int val = snd_soc_read(codec, reg) & mask;
> +
> +	if (shift != 0 && val != 0)
> +		val = val >> shift;
> +	ucontrol->value.enumerated.item[0] = val ^ invert;

...it seems weird that the code actually reads back the enumeration
status, even if we're in the middle of strobing it should be a very
brief, transitory, status which it isn't really worth going to the
effort of reporting.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]