From: greg <gregkh@linuxfoundation.org>
To: yan <clouds.yan@gmail.com>
Cc: kernel <linux-kernel@vger.kernel.org>, message <message.get@gmail.com>
Subject: Re: [PATCH 2/4][Trivial] lib/kobject.c : Check parameter in kobject_set_name
Date: Mon, 23 Apr 2012 13:39:24 -0700 [thread overview]
Message-ID: <20120423203924.GB13075@kroah.com> (raw)
In-Reply-To: <1335000692.2188.10.camel@yan>
On Sat, Apr 21, 2012 at 05:31:24PM +0800, yan wrote:
> kobject_set_name is exported and is just a wrapper for kobject_set_name_vargs
> which does not check its parameter kobj.
> So check this parameter in kobject_set_name.
I have the same objection to this patch, why is it needed? All
in-kernel users do this properly, so the patch isn't needed.
Remember, kernel programming isn't always about being defensive.
greg k-h
prev parent reply other threads:[~2012-04-23 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 9:31 [PATCH 2/4][Trivial] lib/kobject.c : Check parameter in kobject_set_name yan
2012-04-23 20:39 ` greg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423203924.GB13075@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clouds.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=message.get@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.