From: greg <gregkh@linuxfoundation.org>
To: yan <clouds.yan@gmail.com>
Cc: kernel <linux-kernel@vger.kernel.org>, message <message.get@gmail.com>
Subject: Re: [PATCH 4/4][Trivial] lib/kobject.c : check parameter in kobject_init_and_add
Date: Mon, 23 Apr 2012 13:41:18 -0700 [thread overview]
Message-ID: <20120423204118.GD13075@kroah.com> (raw)
In-Reply-To: <1335003475.2188.43.camel@yan>
On Sat, Apr 21, 2012 at 06:17:49PM +0800, yan wrote:
> If user turns to the simple interface kobject_init_and_add
> and gives a null kobject, kobject_init can detect it but
> just dumps the stack. Then there is:
> -->kobject_add_varg
> -->kobject_set_name_vargs
> In the end, it will reference kobj->name and we have an oops.
>
> Check whether we have a valid kobject in kobject_init_and_add.
Why would anyone ever call this function without a valid kobject?
Again, sorry, this patch isn't ok.
greg k-h
prev parent reply other threads:[~2012-04-23 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 10:17 [PATCH 4/4][Trivial] lib/kobject.c : check parameter in kobject_init_and_add yan
2012-04-23 20:41 ` greg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423204118.GD13075@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clouds.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=message.get@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.