From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Tue, 24 Apr 2012 08:54:26 +0100 Subject: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality. In-Reply-To: <20120424013841.GB26306@S2101-09.ap.freescale.net> References: <20120420020816.GH22219@S2101-09.ap.freescale.net> <20120423051813.GM26306@S2101-09.ap.freescale.net> <20120423062739.GX3852@pengutronix.de> <20120423065259.GR26306@S2101-09.ap.freescale.net> <20120423065623.GA3852@pengutronix.de> <20120423071013.GS26306@S2101-09.ap.freescale.net> <20120423074856.GU20478@pengutronix.de> <20120424013841.GB26306@S2101-09.ap.freescale.net> Message-ID: <20120424075426.GP24211@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote: > On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: > > >> Let me try last time. ?What about having a late_initcall hook in > > >> machine_desc? > > > > > > Also fine with me. > > > > > > > Shall I add Shawn's patch to my imx cpuidle patchset or should the > > arch/arm/kernel/setup.c and arch.h changes be submitted separately? > > If separately, Shawn, did you want to submit this patch or should I? > > > Strange. Russell is not in the Cc list. I remember I added Russell > into Cc when I propose the idea. Added him again. I didn't see any message in this thread cc'd to me, but that's not to say I hadn't already read this patch. I don't have any comment against it, but I do wonder how often this hook would be used. We do seem to have quite a number of late_initcall()s in arch/arm/mach-*, so it seems to be a good idea - provided someone's willing to convert all those users of late_initcall()s. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755339Ab2DXHyk (ORCPT ); Tue, 24 Apr 2012 03:54:40 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:45583 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190Ab2DXHyj (ORCPT ); Tue, 24 Apr 2012 03:54:39 -0400 Date: Tue, 24 Apr 2012 08:54:26 +0100 From: Russell King - ARM Linux To: Shawn Guo Cc: Rob Lee , Sascha Hauer , linaro-dev@lists.linaro.org, patches@linaro.org, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, Amit Kucheria , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality. Message-ID: <20120424075426.GP24211@n2100.arm.linux.org.uk> References: <20120420020816.GH22219@S2101-09.ap.freescale.net> <20120423051813.GM26306@S2101-09.ap.freescale.net> <20120423062739.GX3852@pengutronix.de> <20120423065259.GR26306@S2101-09.ap.freescale.net> <20120423065623.GA3852@pengutronix.de> <20120423071013.GS26306@S2101-09.ap.freescale.net> <20120423074856.GU20478@pengutronix.de> <20120424013841.GB26306@S2101-09.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20120424013841.GB26306@S2101-09.ap.freescale.net> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote: > On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: > > >> Let me try last time.  What about having a late_initcall hook in > > >> machine_desc? > > > > > > Also fine with me. > > > > > > > Shall I add Shawn's patch to my imx cpuidle patchset or should the > > arch/arm/kernel/setup.c and arch.h changes be submitted separately? > > If separately, Shawn, did you want to submit this patch or should I? > > > Strange. Russell is not in the Cc list. I remember I added Russell > into Cc when I propose the idea. Added him again. I didn't see any message in this thread cc'd to me, but that's not to say I hadn't already read this patch. I don't have any comment against it, but I do wonder how often this hook would be used. We do seem to have quite a number of late_initcall()s in arch/arm/mach-*, so it seems to be a good idea - provided someone's willing to convert all those users of late_initcall()s.