All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP4: panda: add statics to remove warnings
Date: Tue, 24 Apr 2012 10:16:31 -0700	[thread overview]
Message-ID: <20120424171630.GQ3739@atomide.com> (raw)
In-Reply-To: <1335166780-5899-1-git-send-email-tomi.valkeinen@ti.com>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> Add statics to board-omap4-panda.c's internal functions and data
> structures to remove warnings.

Care to update with the warnings produced?

Tony
 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
>  arch/arm/mach-omap2/board-omap4panda.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index 1b782ba..8216e5f 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -231,7 +231,7 @@ static struct platform_device omap_vwlan_device = {
>  	},
>  };
>  
> -struct wl12xx_platform_data omap_panda_wlan_data  __initdata = {
> +static struct wl12xx_platform_data omap_panda_wlan_data  __initdata = {
>  	/* PANDA ref clock is 38.4 MHz */
>  	.board_ref_clock = 2,
>  };
> @@ -438,7 +438,7 @@ static struct panel_dvi_platform_data omap4_dvi_panel = {
>  	.i2c_bus_num = 3,
>  };
>  
> -struct omap_dss_device omap4_panda_dvi_device = {
> +static struct omap_dss_device omap4_panda_dvi_device = {
>  	.type			= OMAP_DISPLAY_TYPE_DPI,
>  	.name			= "dvi",
>  	.driver_name		= "dvi",
> @@ -448,7 +448,7 @@ struct omap_dss_device omap4_panda_dvi_device = {
>  	.channel		= OMAP_DSS_CHANNEL_LCD2,
>  };
>  
> -int __init omap4_panda_dvi_init(void)
> +static int __init omap4_panda_dvi_init(void)
>  {
>  	int r;
>  
> @@ -509,7 +509,7 @@ static struct omap_dss_board_info omap4_panda_dss_data = {
>  	.default_device	= &omap4_panda_dvi_device,
>  };
>  
> -void __init omap4_panda_display_init(void)
> +static void __init omap4_panda_display_init(void)
>  {
>  	int r;
>  
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-04-24 17:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  7:39 [PATCH] OMAP4: panda: add statics to remove warnings Tomi Valkeinen
2012-04-24 17:16 ` Tony Lindgren [this message]
2012-04-25 12:29   ` Tomi Valkeinen
2012-05-04 19:29     ` Tony Lindgren
2012-05-11 12:55       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120424171630.GQ3739@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.