Re: [RFC PATCH v2 1/2] can: add tx/rx LED trigger support

[Fabio Baltieri <fabio.baltieri@gmail.com>]

On Tue, Apr 24, 2012 at 07:16:38AM +0200, Oliver Hartkopp wrote:
> On 23.04.2012 23:02, Fabio Baltieri wrote:
> 
> > This patch implements the functions to add two LED triggers, named
> > <ifname>-tx and <ifname>-rx, to a canbus device driver.
> 
> 
> Hello Fabio,

Hi Oliver,

> to me it looks really good now. I understand everything of the idea at first
> sight which is a good indicator for simple code ;-)

Thanks!

> The only remark i currently have is ...
> 
> > 
> > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> > index bb709fd..74d6bfb 100644
> > --- a/drivers/net/can/Kconfig
> > +++ b/drivers/net/can/Kconfig
> > @@ -54,6 +54,19 @@ config CAN_CALC_BITTIMING
> >  	  arguments "tq", "prop_seg", "phase_seg1", "phase_seg2" and "sjw".
> >  	  If unsure, say Y.
> >  
> > +config CAN_LEDS
> > +	bool "Enable LED triggers for Netlink based drivers"
> > +	depends on CAN
> 
> 
> CAN_DEV and this entire Kconfig content itself depends on CAN (see at the top
> of this Kconfig) so you can omit that line.

You're right, that was a leftover from the v1.

Removed for v3.

Regards,
Fabio