From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: Re: [PATCH] fs: remove 8 bytes of padding from struct writeback_control on 64 bit builds Date: Wed, 25 Apr 2012 21:57:34 +0800 Message-ID: <20120425135734.GA4995@localhost> References: <1335361985.1885.16.camel@castor.rsk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lkml , linux-fsdevel , Jan Kara To: Richard Kennedy Return-path: Content-Disposition: inline In-Reply-To: <1335361985.1885.16.camel@castor.rsk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Apr 25, 2012 at 02:53:05PM +0100, Richard Kennedy wrote: > Reorder structure writeback_control to remove 8 bytes of padding on 64 > bit builds, this shrinks its size from 48 to 40 bytes. > > This structure is always on the stack and uses C99 named initialisation, > so should be safe and have a small impact on stack usage. > > Signed-off-by: Richard Kennedy > > -- > > patch against v3.4-rc4 > compiled and tested on x86_64 > > I've been running my desktop with this patch applied for several days > and have not seen any problems. > regards > Richard Applied, thanks! Fengguang