From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX2: Support splash screen
Date: Thu, 26 Apr 2012 17:30:24 +0200 [thread overview]
Message-ID: <20120426173024.1585ecac@wker> (raw)
In-Reply-To: <4F995DAB.4070802@exertus.fi>
Hi Timo,
On Thu, 26 Apr 2012 17:37:31 +0300
Timo Ketola <timo@exertus.fi> wrote:
...
> Thanks for the review. Everything else is clear, but...
>
> On 26.04.2012 14:51, Anatolij Gustschin wrote:
> ...
> >> +++ b/drivers/video/mx2fb.c
> >> @@ -0,0 +1,92 @@
> >
> > Please add Copyright info here.
> ...
> >> +++ b/include/mx2fb.h
> ...
> > Please consider Stefano's comment regarding copyright header.
>
> I'm a little lost here. The original work is this:
>
> http://www.imxdev.org/wiki/images/d/d0/U-boot-splash.tar.gz
>
> from here:
>
> http://www.imxdev.org/wiki/index.php?title=I.MX25_PDK_U-boot_SplashScreen
>
> There is also a u-boot.spec.in file in the package which says:
>
> License : GPL
> Vendor : Freescale
> Packager : MAD
>
> Now, can I really just edit the mx2fb.h copyright notice to say "V2 or
> later" and copy it into the mx2fb.h? If I do that, add the imxdev.org
> links into the commit message and tersely say there how I changed the
> source (left out 24bpp and splash_is_in_mmc support), would that be good
> enough?
Yes, I think so. The original header in mx2fb.h mentions GPLv2 or later.
You should add similar header to mx2fb.c also, adding a header like
/*
* Copyright 2004-2009 Freescale Semiconductor, Inc.
*
* This file is released under the terms of GPL v2 and any later version.
* See the file COPYING in the root directory of the source tree for details.
*/
should be enough.
Thanks,
Anatolij
next prev parent reply other threads:[~2012-04-26 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 8:54 [U-Boot] [PATCH 0/1] i.MX2: Support splash screen Timo Ketola
2012-04-18 8:54 ` [U-Boot] [PATCH] " Timo Ketola
2012-04-18 9:26 ` Wolfgang Denk
2012-04-18 10:47 ` Stefano Babic
2012-04-20 11:01 ` [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation Timo Ketola
2012-04-20 11:01 ` [U-Boot] [PATCH] i.MX25: lcdc: Add register definitions Timo Ketola
2012-04-26 11:53 ` Anatolij Gustschin
2012-04-26 9:57 ` [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation Anatolij Gustschin
2012-04-26 11:18 ` Timo Ketola
2012-04-26 12:01 ` Anatolij Gustschin
2012-04-26 11:51 ` [U-Boot] [PATCH] i.MX2: Support splash screen Anatolij Gustschin
2012-04-26 14:37 ` Timo Ketola
2012-04-26 15:30 ` Anatolij Gustschin [this message]
2012-04-18 9:26 ` [U-Boot] [PATCH 0/1] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426173024.1585ecac@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.