From: Josef Bacik <josef@redhat.com>
To: Jim Meyering <jim@meyering.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH] Btrfs: avoid buffer overrun in btrfs_printk
Date: Thu, 26 Apr 2012 14:22:30 -0400 [thread overview]
Message-ID: <20120426182230.GA1890@localhost.localdomain> (raw)
In-Reply-To: <87vckmwiwv.fsf@rho.meyering.net>
On Thu, Apr 26, 2012 at 06:35:12PM +0200, Jim Meyering wrote:
>
> The buffer read-overrun would be triggered by a printk format
> starting with <N>, where N is a single digit. NUL-terminate
> after strncpy. Use memcpy, not strncpy, since we know the
> string we're copying fits in the destination buffer and
> contains no NUL byte.
>
> Signed-off-by: Jim Meyering <meyering@redhat.com>
Reviewed-by: Josef Bacik <josef@redhat.com
I just noticed this but could you send to linux-btrfs@vger.kernel.org from now
on? Thanks,
Josef
prev parent reply other threads:[~2012-04-26 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 16:35 [PATCH] Btrfs: avoid buffer overrun in btrfs_printk Jim Meyering
2012-04-26 18:22 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426182230.GA1890@localhost.localdomain \
--to=josef@redhat.com \
--cc=jim@meyering.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.