From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 2/3] virtio: balloon: let host know of updated balloon size before module removal
Date: Thu, 26 Apr 2012 23:50:41 +0300 [thread overview]
Message-ID: <20120426205041.GA30261@redhat.com> (raw)
In-Reply-To: <22d281728c195b275e909be36535d9e14cefff27.1335467427.git.amit.shah@redhat.com>
On Fri, Apr 27, 2012 at 12:45:56AM +0530, Amit Shah wrote:
> When the balloon module is removed, we deflate the balloon, reclaiming
> all the pages that were given to the host. However, we don't update the
> config values for the new balloon size, resulting in the host showing
> outdated balloon values.
>
> The size update is done after each leak and fill operation, only the
> module removal case was left out.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
applied,
thanks
the rest are 3.5 material imo
> ---
> drivers/virtio/virtio_balloon.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 6921326..04baad6 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -390,6 +390,7 @@ static void __devexit virtballoon_remove(struct virtio_device *vdev)
> /* There might be pages left in the balloon: free them. */
> while (vb->num_pages)
> leak_balloon(vb, vb->num_pages);
> + update_balloon_size(vb);
>
> /* Now we reset the device so we can clean up the queues. */
> vdev->config->reset(vdev);
> --
> 1.7.7.6
next prev parent reply other threads:[~2012-04-26 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 19:15 [PATCH 0/3] virtio: balloon: cleanups and a fix Amit Shah
2012-04-26 19:15 ` [PATCH 1/3] virtio: balloon: drop restore_common() Amit Shah
2012-04-26 19:15 ` [PATCH 2/3] virtio: balloon: let host know of updated balloon size before module removal Amit Shah
2012-04-26 20:50 ` Michael S. Tsirkin [this message]
2012-04-26 19:15 ` [PATCH 3/3] virtio: balloon: separate out common code between remove and freeze functions Amit Shah
2012-04-26 20:07 ` [PATCH 0/3] virtio: balloon: cleanups and a fix Michael S. Tsirkin
2012-04-26 20:15 ` Amit Shah
2012-05-07 3:53 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120426205041.GA30261@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.