From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] spi: pl022: Fix calculate_effective_freq() Date: Fri, 27 Apr 2012 10:48:23 -0600 Message-ID: <20120427164823.AAA713E0B4D@localhost> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, vinit.shenoy-qxv4g6HH51o@public.gmane.org, Chris Blair To: Linus Walleij , Viresh Kumar Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, 26 Apr 2012 10:29:19 +0200, Linus Walleij wrote: > On Thu, Apr 19, 2012 at 11:14 AM, Viresh Kumar wrote: > > > calculate_effective_freq() was still not optimized and there were cases when it > > returned without error and with values of cpsr and scr as zero. > > > > Also, the variable named found is not used well. > > > > This patch targets to optimize and correct this routine. Tested for SPEAr. > > > > Signed-off-by: Viresh Kumar > > Tested-by: Vinit Kamalaksha Shenoy > > Looks good to me. > Acked-by: Linus Walleij > > Yours, > Linus Walleij Applied, thanks. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/