diff for duplicates of <20120427190332.GG28062@n2100.arm.linux.org.uk> diff --git a/a/1.txt b/N1/1.txt index b33d9ec..aa4e231 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Fri, Apr 27, 2012 at 09:00:22PM +0200, Linus Walleij wrote: > On Mon, Apr 23, 2012 at 6:05 PM, Russell King > <rmk+kernel@arm.linux.org.uk> wrote: > -> > Add DMA engine support to the OMAP HSMMC driver. This supplements the +> > Add DMA engine support to the OMAP HSMMC driver. ?This supplements the > > private DMA API implementation contained within this driver, and the > > driver can be switched at build time between using DMA engine and the > > private DMA API. @@ -12,18 +12,18 @@ On Fri, Apr 27, 2012 at 09:00:22PM +0200, Linus Walleij wrote: > Great, > > > +#if 1 -> > + sig = host->dma_line_rx; -> > + host->rx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig); -> > + if (!host->rx_chan) { -> > + dev_warn(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", sig); -> > + } +> > + ? ? ? ? ? ? ? sig = host->dma_line_rx; +> > + ? ? ? ? ? ? ? host->rx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig); +> > + ? ? ? ? ? ? ? if (!host->rx_chan) { +> > + ? ? ? ? ? ? ? ? ? ? ? dev_warn(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", sig); +> > + ? ? ? ? ? ? ? } > > +#endif > > +#if 1 -> > + sig = host->dma_line_tx; -> > + host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig); -> > + if (!host->tx_chan) { -> > + dev_warn(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", sig); -> > + } +> > + ? ? ? ? ? ? ? sig = host->dma_line_tx; +> > + ? ? ? ? ? ? ? host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig); +> > + ? ? ? ? ? ? ? if (!host->tx_chan) { +> > + ? ? ? ? ? ? ? ? ? ? ? dev_warn(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", sig); +> > + ? ? ? ? ? ? ? } > > +#endif > > Are these development artifacts? @@ -36,7 +36,3 @@ change the relevant #if to zero at build time. I don't think it warrants config symbols or trying to do it via module params as its just a stepping stone through the process. --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 8a32298..e9ed000 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,17 @@ "ref\020120423160409.GE24299@n2100.arm.linux.org.uk\0" "ref\0E1SMLlv-0002WI-8a@rmk-PC.arm.linux.org.uk\0" "ref\0CACRpkdZPEnPTpp+vwJed4ZkXLNjEVUz==YVvwg_bhuUOyD3Fxg@mail.gmail.com\0" - "From\0Russell King - ARM Linux <linux@arm.linux.org.uk>\0" - "Subject\0Re: [PATCH 05/12] mmc: omap_hsmmc: add DMA engine support\0" + "From\0linux@arm.linux.org.uk (Russell King - ARM Linux)\0" + "Subject\0[PATCH 05/12] mmc: omap_hsmmc: add DMA engine support\0" "Date\0Fri, 27 Apr 2012 20:03:32 +0100\0" - "To\0Linus Walleij <linus.walleij@linaro.org>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - linux-omap@vger.kernel.org - linux-mmc@vger.kernel.org - " Chris Ball <cjb@laptop.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Fri, Apr 27, 2012 at 09:00:22PM +0200, Linus Walleij wrote:\n" "> On Mon, Apr 23, 2012 at 6:05 PM, Russell King\n" "> <rmk+kernel@arm.linux.org.uk> wrote:\n" "> \n" - "> > Add DMA engine support to the OMAP HSMMC driver. \302\240This supplements the\n" + "> > Add DMA engine support to the OMAP HSMMC driver. ?This supplements the\n" "> > private DMA API implementation contained within this driver, and the\n" "> > driver can be switched at build time between using DMA engine and the\n" "> > private DMA API.\n" @@ -25,18 +21,18 @@ "> Great,\n" "> \n" "> > +#if 1\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 sig = host->dma_line_rx;\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 host->rx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (!host->rx_chan) {\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 dev_warn(mmc_dev(host->mmc), \"unable to obtain RX DMA engine channel %u\\n\", sig);\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 }\n" + "> > + ? ? ? ? ? ? ? sig = host->dma_line_rx;\n" + "> > + ? ? ? ? ? ? ? host->rx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);\n" + "> > + ? ? ? ? ? ? ? if (!host->rx_chan) {\n" + "> > + ? ? ? ? ? ? ? ? ? ? ? dev_warn(mmc_dev(host->mmc), \"unable to obtain RX DMA engine channel %u\\n\", sig);\n" + "> > + ? ? ? ? ? ? ? }\n" "> > +#endif\n" "> > +#if 1\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 sig = host->dma_line_tx;\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (!host->tx_chan) {\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 dev_warn(mmc_dev(host->mmc), \"unable to obtain TX DMA engine channel %u\\n\", sig);\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 }\n" + "> > + ? ? ? ? ? ? ? sig = host->dma_line_tx;\n" + "> > + ? ? ? ? ? ? ? host->tx_chan = dma_request_channel(mask, omap_dma_filter_fn, &sig);\n" + "> > + ? ? ? ? ? ? ? if (!host->tx_chan) {\n" + "> > + ? ? ? ? ? ? ? ? ? ? ? dev_warn(mmc_dev(host->mmc), \"unable to obtain TX DMA engine channel %u\\n\", sig);\n" + "> > + ? ? ? ? ? ? ? }\n" "> > +#endif\n" "> \n" "> Are these development artifacts?\n" @@ -48,10 +44,6 @@ "change the relevant #if to zero at build time.\n" "\n" "I don't think it warrants config symbols or trying to do it via module\n" - "params as its just a stepping stone through the process.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + params as its just a stepping stone through the process. -59971c519668a237d1b53607848f49bb1b7784b864322431f866dc283c60d587 +cb301cf9525ac037929b09d37be6a601ad0789f2254c6c63709da4621d8ddcf3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.