From: Matthew Wilcox <matthew@wil.cx>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
ext4 development <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>,
Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
Subject: Re: [PATCH] vfs: allow custom EOF in generic_file_llseek code
Date: Sat, 28 Apr 2012 12:33:15 -0600 [thread overview]
Message-ID: <20120428183315.GA28349@parisc-linux.org> (raw)
In-Reply-To: <4F9AC770.8080004@redhat.com>
On Fri, Apr 27, 2012 at 11:21:04AM -0500, Eric Sandeen wrote:
> As far as I know, this does not fix any bugs - nfs in the kernel
> doesn't use SEEK_END, and I don't know of any user who does. But
> some ext4 folks seem keen on doing the right thing here, and I can't
> really argue.
I like it. In particular it removes a lot of calls to i_size_read() which
may have some nice benefits on 32-bit systems.
However, there is only one call to generic_file_llseek_size() in the
kernel (and it's in ext4!) I would suggest simply changing the prototype
of generic_file_llseek_size ... or if you insist, just renaming it to
generic_file_llseek_size_eof().
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2012-04-28 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 16:21 [PATCH] vfs: allow custom EOF in generic_file_llseek code Eric Sandeen
2012-04-27 16:28 ` Eric Sandeen
2012-04-27 22:47 ` Bernd Schubert
2012-04-27 23:01 ` Eric Sandeen
2012-04-28 18:33 ` Matthew Wilcox [this message]
2012-04-30 14:17 ` Eric Sandeen
2012-04-30 18:11 ` [PATCH 1/3 V2] " Eric Sandeen
2012-04-30 18:14 ` [PATCH 2/3] ext4: use core vfs llseek code for dir seeks Eric Sandeen
2012-04-30 18:16 ` [PATCH 3/3] ext3: pass custom EOF to generic_file_llseek_size() Eric Sandeen
2012-04-30 22:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120428183315.GA28349@parisc-linux.org \
--to=matthew@wil.cx \
--cc=adilger@dilger.ca \
--cc=bernd.schubert@itwm.fraunhofer.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.