Re: [PATCH 01/02] fixed coding style issue with comments

[Andi Shyti <andi.shyti@gmail.com>]

Hi,

On Sun, Apr 29, 2012 at 06:50:14PM +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to comments

[...]

>  	if (crate != rate) {
>  		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
> -		// runtime->rate = crate;
> +		/* runtime->rate = crate; */
>  	}


If you really want ti fix some style issues, you could also split
the snd_printd() line that is over 80 characters.
Moreover, this comment is not really meaningful, I would remove
it at all.

I would prefer something like

-	if (create != rate) {
+	if (create != rate)
-		snd_printd(KERN_WARNING "current rate %d is different from the runtime rate %d\n", crate, rate);
+		snd_printd(KERN_WARNING
+			"current rate %d is different from runtime rate %d\n",
+			crate, rate);
-		// runtime->rate = crate;
-  	}

Andi