All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@gmail.com>
To: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
	cw00.choi@samsung.com, Chiwoong byun <woong.byun@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH] MFD : add MAX77686 mfd driver
Date: Mon, 30 Apr 2012 11:17:49 +0200	[thread overview]
Message-ID: <20120430091748.GA2460@andi> (raw)
In-Reply-To: <1335776022-4571-1-git-send-email-jonghwa3.lee@samsung.com>

Hi,

> +	mutex_lock(&max77686->iolock);
> +	ret = i2c_smbus_read_i2c_block_data(i2c, reg, count, buf);
> +	mutex_unlock(&max77686->iolock);

Is it relly necessay to lock whenever you read/write from/to the
i2c bus? Considering also that these are exported function,
someone else may lock here before, so we can have a double
locking on the same mutex.

Andi

  reply	other threads:[~2012-04-30  9:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30  8:53 [PATCH] MFD : add MAX77686 mfd driver Jonghwa Lee
2012-04-30  9:17 ` Andi Shyti [this message]
2012-05-02  5:02   ` jonghwa3.lee
2012-05-02  9:28     ` Andi Shyti
2012-05-01 16:58 ` Mark Brown
2012-05-02  5:01   ` jonghwa3.lee
2012-05-02  8:52     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-04-30  8:57 함명주

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120430091748.GA2460@andi \
    --to=andi.shyti@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=jonghwa3.lee@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    --cc=woong.byun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.