From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Thornber Subject: Re: [PATCH 2/2] dm thin: support for non power of 2 pool blocksize Date: Tue, 1 May 2012 10:41:32 +0100 Message-ID: <20120501094131.GA5602@ubuntu> References: <1335588269-807-1-git-send-email-snitzer@redhat.com> <1335588269-807-2-git-send-email-snitzer@redhat.com> <20120430095555.GA5955@ubuntu> <20120430173347.GB19033@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120430173347.GB19033@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: dm-devel@redhat.com, ejt@redhat.com, agk@redhat.com List-Id: dm-devel.ids On Mon, Apr 30, 2012 at 01:33:47PM -0400, Mike Snitzer wrote: > Yes. But imposing this restriction was motivated by and the "attempt to > access beyond end of device" failures I saw with test_origin_unchanged > (I shared more details about this in private mail to you and kabi on > 4/25 -- making the pool size a multiple of the non power of 2 blocksize > resolved that failure). This is the wrong fix; you're just hiding the real issue.