All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] i.MX6: mx6q_sabrelite: add SATA bindings
Date: Tue, 1 May 2012 23:11:07 +0200	[thread overview]
Message-ID: <201205012311.07224.marex@denx.de> (raw)
In-Reply-To: <4FA03F46.5010203@boundarydevices.com>

Dear Eric Nelson,

> On 05/01/2012 12:25 PM, Marek Vasut wrote:
> > Dear Eric Nelson,
> > 
> >> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
> >> ---
> >> V2 has been stripped of the board-independent changes and
> >> uses clrsetbits_le32() instead of twiddling bits by hand.
> >> 
> >> V3 returns immediately from setup_sata() if enable_sata_clock()
> >> returns an error.
> >> 
> >> V4 removes extra #include and addresses a style issue as discussed
> >> on the ML.
> > 
> > It's still there ;-)
> > 
>  >> <snip>
> >> 
> >> +			|IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
> >> +			|IOMUXC_GPR13_SATA_PHY_1_SLOW);
> >> +
> >> 
> >> +	return 0 ;<---- here :-)
> 
> My eyes are clearly not as finely tuned as yours...

1 dioptry on left eye, lazy-eye blindness on the right one ;-)

> <thought to self>
> What are the odd that I could tweak checkpatch.pl
> without introducing another style issue?
> </thought to self>

That'd be awesome.

> V5 forthcoming...

Thanks :)

Best regards,
Marek Vasut

  reply	other threads:[~2012-05-01 21:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-April/#123169>
2012-05-01 19:24 ` [U-Boot] [PATCH V4] i.MX6: mx6q_sabrelite: add SATA bindings Eric Nelson
2012-05-01 19:25   ` Marek Vasut
2012-05-01 19:53     ` Eric Nelson
2012-05-01 21:11       ` Marek Vasut [this message]
2012-05-01 21:58         ` Eric Nelson
2012-05-01 19:55 ` [U-Boot] [PATCH V5] " Eric Nelson
2012-05-01 20:09   ` Marek Vasut
2012-05-01 20:23     ` Eric Nelson
2012-05-06 17:06   ` Stefano Babic
2012-05-06 17:10   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205012311.07224.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.