From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Russ Dill <Russ.Dill@ti.com>
Subject: [PATCH 1/2] ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
Date: Tue, 01 May 2012 20:44:40 -0400 [thread overview]
Message-ID: <20120502005415.756997253@goodmis.org> (raw)
In-Reply-To: 20120502004439.965120020@goodmis.org
[-- Attachment #1: 0001-ktest.pl-Fix-combined-usage-of-BISECT_REVERSE-and-BI.patch --]
[-- Type: text/plain, Size: 1063 bytes --]
From: Russ Dill <Russ.Dill@ti.com>
When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
testing, build failures are treated as boot or test failures and
'git bisect bad' is executed instead of 'git bisect skip'. This is because
the $ret value of -1 is treated as a build failure, but the $reverse_bisect
logic does not properly handle this.
Simple fix, only invert it if it is positive.
Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com
Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/ktest.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 95d6a6f..d2ede59 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2192,7 +2192,7 @@ sub run_bisect {
}
# Are we looking for where it worked, not failed?
- if ($reverse_bisect) {
+ if ($reverse_bisect && $ret >= 0) {
$ret = !$ret;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-05-02 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 0:44 [PATCH 0/2] [GIT PULL] ktest: A couple of fixes Steven Rostedt
2012-05-02 0:44 ` Steven Rostedt [this message]
2012-05-02 0:44 ` [PATCH 2/2] ktest: Fix reboot on success stopping all reboots Steven Rostedt
2012-05-02 2:58 ` [PATCH 0/2] [GIT PULL] ktest: A couple of fixes Linus Torvalds
2012-05-02 3:30 ` Stephen Rothwell
2012-05-02 3:49 ` Junio C Hamano
2012-05-02 13:44 ` Steven Rostedt
2012-05-02 20:14 ` Junio C Hamano
2012-05-03 0:07 ` Steven Rostedt
2012-05-03 0:33 ` Jakub Narebski
2012-05-03 1:52 ` Steven Rostedt
2012-05-03 2:06 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502005415.756997253@goodmis.org \
--to=rostedt@goodmis.org \
--cc=Russ.Dill@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.