Re: [GIT PULL 0/5] perf/annotate fixes and improvements

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Wed, May 02, 2012 at 09:46:43PM +0200, Peter Zijlstra escreveu:
> On Wed, 2012-05-02 at 16:42 -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > avtab_search_node
> >                push   %rbp
> >                mov    %rsp,%rbp
> >              → callq  mcount
> >                movzwl 0x6(%rsi),%edx
> >                and    $0x7fff,%dx
> >                test   %rdi,%rdi
> >        ┌─────↓ jne    20
> >        │  17:  xor    %eax,%eax
> >        │  19:  leaveq
> >        │     ← retq
> >        │       nopl   0x0(%rax,%rax,1)
> >        └─→20:  mov    (%rdi),%rax
> >                test   %rax,%rax
> >              ↑ je     17
> >                movzwl (%rsi),%ecx
> >                movzwl 0x2(%rsi),%r9d
> >                movzwl 0x4(%rsi),%r8d
> >                movzwl %cx,%esi
> >                movzwl %r9w,%r10d
> >                shl    $0x9,%esi
> >                lea    (%rsi,%r10,4),%esi
> >                lea    (%r8,%rsi,1),%esi
> >                and    0x10(%rdi),%si
> >                movzwl %si,%esi
> >                mov    (%rax,%rsi,8),%rax
> >   1.63         test   %rax,%rax
> >              ↑ je     19
> >                nopw   0x0(%rax,%rax,1)
> >   4.88    60:  cmp    %cx,(%rax)
> >              ↓ jne    7e
> >                cmp    %r9w,0x2(%rax)
> >              ↓ jne    7e
> >                cmp    %r8w,0x4(%rax)
> >              ↓ jne    79
> >                test   %dx,0x6(%rax)
> >              ↑ jne    19
> >           79:  cmp    %r8w,0x4(%rax)
> >  86.99    7e:↑ ja     17
> >   3.25         mov    0x10(%rax),%rax
> >   3.25         test   %rax,%rax
> >              ↑ jne    60
> >                leaveq
> >              ← retq
> > 
> > . Changes:
> > 
> >         - Don't show the big vertical line. 
> 
> Not sure about that, loosing that separator makes it looks messy.

It was a request from Linus:

commit 3e8b5ddf17d4639d41bc57ecfb51633815b70e49
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date:   Fri Apr 27 16:44:56 2012 -0300

    perf annotate browser: Remove the vertical line after the percentages
    
    It is confusing when used with jump -> target lines.
    
    Requested-by: Linus Torvalds <torvalds@linux-foundation.org>

Make it configurable? Press 'S' and you get a separator? Linus?

- Arnaldo