All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Package proposed: read-edid
Date: Thu, 3 May 2012 08:52:56 +0200	[thread overview]
Message-ID: <20120503085256.5876db5c@skate> (raw)
In-Reply-To: <20120503051820.GA20002@sapphire.tkos.co.il>

Hello Dimitry,

Thanks for your contribution! Baruch has raised valid points in his
review, I will add one more comment below.

Le Thu, 3 May 2012 08:18:20 +0300,
Baruch Siach <baruch@tkos.co.il> a ?crit :

> +define READ_EDID_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/bin
> +	$(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/bin
> +endef

This should rather be:

+define READ_EDID_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/get-edid $(TARGET_DIR)/usr/bin/get-edid
+	$(INSTALL) -D -m 0755 $(@D)/parse-edid $(TARGET_DIR)/usr/bin/parse-edid
+endef

I.e, you need to repeat the filename in the second argument, and those
non-essential binaries should probably live in usr/bin/ rather than bin/.

Can you take Baruch and my comments into account and post an updated
version?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2012-05-03  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-03  4:36 [Buildroot] [PATCH] Package proposed: read-edid Dimitry Golubovsky
2012-05-03  5:18 ` Baruch Siach
2012-05-03  6:52   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120503085256.5876db5c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.