From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Jung Subject: Re: [PATCH 1/1] battery: only refresh the sysfs files when pertinant information changes Date: Fri, 4 May 2012 15:29:06 +0200 Message-ID: <201205041529.07142.post@ralfj.de> References: <20120503124708.GA18622@srcf.ucam.org> <1336052907-15084-1-git-send-email-apw@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from ralfj.de ([85.214.220.216]:54235 "EHLO ralfj.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010Ab2EDN3L (ORCPT ); Fri, 4 May 2012 09:29:11 -0400 In-Reply-To: <1336052907-15084-1-git-send-email-apw@canonical.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Whitcroft Cc: Matthew Garrett , "Rafael J. Wysocki" , Jonathan Nieder , ACPI Devel Maling List , Linux-pm mailing list , Adrian Fita , Len Brown , Paolo Scarabelli , linux-kernel@vger.kernel.org Hi, I applied this to 3.4-rc5, and it fixes the issue. Thanks a lot :) > We only need to regenerate the sysfs files when the capacity units > change, avoid the update otherwise. > > Signed-off-by: Andy Whitcroft Tested-by: Ralf Jung > --- > drivers/acpi/battery.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > Based on Matthew's feedback here is a version which optimises > based on the power_unit field as returned from the battery info. > Could someone who suffers from this issue please test this out > and report back. Thanks. > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index 86933ca..7dd3f9f 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -643,11 +643,19 @@ static int acpi_battery_update(struct acpi_battery > *battery) > > static void acpi_battery_refresh(struct acpi_battery *battery) > { > + int power_unit; > + > if (!battery->bat.dev) > return; > > + power_unit = battery->power_unit; > + > acpi_battery_get_info(battery); > - /* The battery may have changed its reporting units. */ > + > + if (power_unit == battery->power_unit) > + return; > + > + /* The battery has changed its reporting units. */ > sysfs_remove_battery(battery); > sysfs_add_battery(battery); > } Kind regards, Ralf Jung