From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 0/4] perf, tool: Fix endian issues
Date: Fri, 4 May 2012 14:59:40 -0300 [thread overview]
Message-ID: <20120504175940.GC29365@infradead.org> (raw)
In-Reply-To: <4FA41481.7000704@gmail.com>
Em Fri, May 04, 2012 at 11:40:17AM -0600, David Ahern escreveu:
> On 5/4/12 11:11 AM, Jiri Olsa wrote:
> >hi,
> >sending fixies to properly handle perf.data endians.
> >
> >v2 changes:
> > - added patches 3 and 4 to handle sample_id_all header endianity
> >
> >Attached patches:
> > 1/4 perf, tool: Handle different endians properly during symbol load
> > 2/4 perf, tool: Carry perf_event_attr bitfield throught different endians
> > 3/4 perf, tool: Handle endianity swap on sample_id_all header data
> > 4/4 perf, tool: Fix 32 bit values endianity swap for sample_id_all header
>
> Have you tested these patches by collecting data on PPC (or other
> big endian) and analyzing on Intel x86 and vice versa?
I think so, but indeed it is good practice to show the sequence made to
test the changes, with sample, short command output before and after.
- Arnaldo
next prev parent reply other threads:[~2012-05-04 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 17:11 [PATCHv2 0/4] perf, tool: Fix endian issues Jiri Olsa
2012-05-04 17:11 ` [PATCH 1/4] perf, tool: Handle different endians properly during symbol load Jiri Olsa
2012-05-04 17:11 ` [PATCH 2/4] perf, tool: Carry perf_event_attr bitfield throught different endians Jiri Olsa
2012-05-04 17:11 ` [PATCH 3/4] perf, tool: Handle endianity swap on sample_id_all header data Jiri Olsa
2012-05-04 17:11 ` [PATCH 4/4] perf, tool: Fix 32 bit values endianity swap for sample_id_all header Jiri Olsa
2012-05-04 17:40 ` [PATCHv2 0/4] perf, tool: Fix endian issues David Ahern
2012-05-04 17:59 ` Arnaldo Carvalho de Melo [this message]
2012-05-04 18:08 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504175940.GC29365@infradead.org \
--to=acme@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.