Re: [PATCH] arm: igep0020: Specify the VPLL2 regulator unconditionally

[Tony Lindgren <tony@atomide.com>]

* Enric Balletbò i Serra <eballetbo@gmail.com> [120427 02:30]:
> 2012/4/23 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> > The supply is connected to the DSS DO-D5 pins and is thus needed for
> > both serial and parallel display interfaces on the igep0030 as well as
> > the igep0020.
> >
> > If the igep0030 module isn't connected to a display, no DSI or DPI
> > display will be specified in board code, and the DSS driver won't enable
> > to VPLL2 regulator anyway.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  arch/arm/mach-omap2/board-igep0020.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
> > index a59ace0..242cdff 100644
> > --- a/arch/arm/mach-omap2/board-igep0020.c
> > +++ b/arch/arm/mach-omap2/board-igep0020.c
> > @@ -539,7 +539,10 @@ static void __init igep_i2c_init(void)
> >  {
> >        int ret;
> >
> > -       omap3_pmic_get_config(&igep_twldata, TWL_COMMON_PDATA_USB, 0);
> > +       omap3_pmic_get_config(&igep_twldata, TWL_COMMON_PDATA_USB,
> > +                             TWL_COMMON_REGULATOR_VPLL2);
> > +       igep_twldata.vpll2->constraints.apply_uV = true;
> > +       igep_twldata.vpll2->constraints.name = "VDVI";
> >
> >        if (machine_is_igep0020()) {
> >                /*
> > @@ -553,10 +556,7 @@ static void __init igep_i2c_init(void)
> >
> >                igep_twldata.keypad     = &igep2_keypad_pdata;
> >                /* Get common pmic data */
> > -               omap3_pmic_get_config(&igep_twldata, TWL_COMMON_PDATA_AUDIO,
> > -                                     TWL_COMMON_REGULATOR_VPLL2);
> > -               igep_twldata.vpll2->constraints.apply_uV = true;
> > -               igep_twldata.vpll2->constraints.name = "VDVI";
> > +               omap3_pmic_get_config(&igep_twldata, TWL_COMMON_PDATA_AUDIO, 0);
> >        }
> >
> >        omap3_pmic_init("twl4030", &igep_twldata);
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Seems good to me.
> 
> Tony, as this is a fix ,may be included ?
> 
> Acked-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com>

Yes seems like a valid fix to me so applying into fixes.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html