From: Gustavo Padovan <gustavo@padovan.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, pkrystad@codeaurora.org
Subject: Re: [PATCHv2 2/2] Bluetooth: Lock the L2CAP channel when sending
Date: Fri, 4 May 2012 21:01:04 -0300 [thread overview]
Message-ID: <20120505000104.GB23728@joana> (raw)
In-Reply-To: <1336166431-4926-3-git-send-email-mathewm@codeaurora.org>
Hi Mat,
* Mat Martineau <mathewm@codeaurora.org> [2012-05-04 14:20:31 -0700]:
> The ERTM and streaming mode transmit queue must only be accessed while
> the L2CAP channel lock is held. Locking the channel before calling
> l2cap_chan_send ensures that multiple threads cannot simultaneously
> manipulate the queue when sending and receiving concurrently.
>
> L2CAP channel locking had previously moved to the l2cap_chan struct
> instead of the associated socket, so some of the old socket locking
> can also be removed in this patch.
>
> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> ---
> include/net/bluetooth/bluetooth.h | 2 --
> net/bluetooth/l2cap_sock.c | 19 +++++++++++--------
> 2 files changed, 11 insertions(+), 10 deletions(-)
Patch has been applied to the bluetooth tree. Thanks.
Gustavo
next prev parent reply other threads:[~2012-05-05 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 21:20 [PATCHv2 0/2] Reworked send locking patches Mat Martineau
2012-05-04 21:20 ` [PATCHv2 1/2] Bluetooth: Restore locking semantics when looking up L2CAP channels Mat Martineau
2012-05-04 21:20 ` [PATCHv2 2/2] Bluetooth: Lock the L2CAP channel when sending Mat Martineau
2012-05-05 0:01 ` Gustavo Padovan [this message]
2012-05-08 7:42 ` Andrei Emeltchenko
2012-05-08 7:44 ` Gustavo Padovan
2012-05-08 7:57 ` Andrei Emeltchenko
2012-05-16 14:50 ` Andrei Emeltchenko
2012-05-16 15:56 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120505000104.GB23728@joana \
--to=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.