Re: [PATCH v3] completion: add new _GIT_complete helper

[Jonathan Nieder <jrnieder@gmail.com>]

Felipe Contreras wrote:
> On Sat, May 5, 2012 at 5:54 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

>> Following a convention similar to the bash-completion project's
>> proposed future convention doesn't really help compatibility.  If we
>> want to be able to include this function in that project without
>> change some day, we'd have to call it _BC_git_complete. :)
>
> No, that's for bash-completion's functions, this is a git bash
> completion function.

Please read again.  "If we want to be able to include this ...".  I
assume we do not, but that would be the reason to follow their
convention to the letter.

[...]
> But wasn't you the one that suggested we follow the bash-completion's
> guidelines, or that was only when the guidelines happened to match
> your preference?

Sorry for the lack of clarity before.  I like to hope that "Because
Jonathan said so" is _never_ the only justification for putting up
with a technical change you disagree with.  In this instance, my
personal justification was "Because our completion scripts are already
using this convention, which happens to come from bash-completion's
guidelines and here are the reasons behind those".

Also, I think you have misunderstood me.  I was asking Gábor for input
because you were proposing changing a convention and I thought Gábor
had been maintaining the completion scripts.  I was not trying to say
"Please don't do this".

I was not inviting you to argue with me.

Kind regards,
Jonathan