All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [mesa PATCH] nv50: handle VP without inputs
Date: Sun, 6 May 2012 20:53:08 +0200	[thread overview]
Message-ID: <20120506185308.GC4311@joi.lan> (raw)

Fixes 3 piglit tests:
general/pos-array
shaders/glsl-novertexdata
shaders/glsl-vs-point-size
and makes shaders/vp-ignore-input not trigger PGRAPH DATA_ERROR
---
It's a bit ugly... If there's a way to fix it properly, I'm open to suggestions.
---
 src/gallium/drivers/nv50/nv50_program.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/gallium/drivers/nv50/nv50_program.c b/src/gallium/drivers/nv50/nv50_program.c
index 48e8db3..c44f537 100644
--- a/src/gallium/drivers/nv50/nv50_program.c
+++ b/src/gallium/drivers/nv50/nv50_program.c
@@ -53,6 +53,13 @@ nv50_vertprog_assign_slots(struct nv50_ir_prog_info *info)
          if (info->in[i].mask & (1 << c))
             info->in[i].slot[c] = n++;
    }
+
+   // Corner case: VP has no inputs, but we will still need to submit data to
+   // draw it. HW will shout at us and won't draw anything if we don't enable
+   // any input, so let's just pretend it's the first one.
+   if (info->numInputs == 0)
+      prog->vp.attrs[0] |= 0xf;
+
    prog->in_nr = info->numInputs;
 
    for (i = 0; i < info->numSysVals; ++i) {
-- 
1.7.8.5

             reply	other threads:[~2012-05-06 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 18:53 Marcin Slusarz [this message]
     [not found] ` <20120506185308.GC4311-OI9uyE9O0yo@public.gmane.org>
2012-05-06 19:05   ` [mesa PATCH] nv50: handle VP without inputs Christoph Bumiller
     [not found]     ` <4FA6CB71.9070308-oe7qfRrRQffzPE21tAIdciO7C/xPubJB@public.gmane.org>
2012-05-06 20:54       ` Marcin Slusarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120506185308.GC4311@joi.lan \
    --to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.