All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Marcin Kościelnicki" <koriakin-mP9o5jsk0RY@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [envytools PATCH] nv50/pgraph: DATA_ERROR 0x24
Date: Sun, 6 May 2012 21:14:56 +0200	[thread overview]
Message-ID: <20120506191456.GE4311@joi.lan> (raw)
In-Reply-To: <4FA6CA9D.5070107-mP9o5jsk0RY@public.gmane.org>

On Sun, May 06, 2012 at 09:01:49PM +0200, Marcin Kościelnicki wrote:
> On 06.05.2012 20:51, Marcin Slusarz wrote:
> >
> > ---
> >   rnndb/nv50_pgraph.xml |    3 +++
> >   1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/rnndb/nv50_pgraph.xml b/rnndb/nv50_pgraph.xml
> > index 92d69ea..6499631 100644
> > --- a/rnndb/nv50_pgraph.xml
> > +++ b/rnndb/nv50_pgraph.xml
> > @@ -93,6 +93,9 @@
> >   	<value value="0x23" name="XY_OUT_OF_BOUNDS">  <!-- m2mf at least. 2d too? -->
> >   		<brief>Your x/y coords exceed the size of your surface.</brief>
> >   	</value>
> > +	<value value="0x24" name="VP_NO_INPUT_MASK">
> > +		<brief>You tried to submit vertices without setting input mask (VP_ATTR_EN).</brief>
> > +	</value>
> >   	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
> >   		<brief>You tried to launch block with more params than allocated s[] space.</brief>
> >   	</value>
> 
> Could we get a better name + description for that? The error happens 
> when there are no enabled inputs (VP_ATTR_EN is set, but is 0), not when 
> it's not set at all. VP_ZERO_INPUTS or VP_NO_INPUTS perhaps?

Yes, that's correct.

> Also, have you checked if that error happens on all submission methods, 
> or just VERTEX_DATA? I don't see why VERTEX_ELEMENT / 
> VERTEX_BUFFER_COUNT would have a problem with 0 inputs.

It definitely has problems with VERTEX_BUFFER_COUNT, only later I discovered
VERTEX_DATA have them too. I didn't check VB_ELEMENT_*, but I bet it's the same
story.

Marcin

---
From: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: [PATCH] nv50/pgraph: DATA_ERROR 0x24

---
 rnndb/nv50_pgraph.xml |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/rnndb/nv50_pgraph.xml b/rnndb/nv50_pgraph.xml
index 92d69ea..aa925fa 100644
--- a/rnndb/nv50_pgraph.xml
+++ b/rnndb/nv50_pgraph.xml
@@ -93,6 +93,9 @@
 	<value value="0x23" name="XY_OUT_OF_BOUNDS"> <!-- m2mf at least. 2d too? -->
 		<brief>Your x/y coords exceed the size of your surface.</brief>
 	</value>
+	<value value="0x24" name="VP_ZERO_INPUTS">
+		<brief>You tried to submit vertices with VP input mask (VP_ATTR_EN) set to 0.</brief>
+	</value>
 	<value value="0x27" name="CP_MORE_PARAMS_THAN_SHARED">
 		<brief>You tried to launch block with more params than allocated s[] space.</brief>
 	</value>
-- 
1.7.8.5
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2012-05-06 19:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 18:51 [envytools PATCH] nv50/pgraph: DATA_ERROR 0x24 Marcin Slusarz
     [not found] ` <20120506185103.GA4311-OI9uyE9O0yo@public.gmane.org>
2012-05-06 19:01   ` Marcin Kościelnicki
     [not found]     ` <4FA6CA9D.5070107-mP9o5jsk0RY@public.gmane.org>
2012-05-06 19:14       ` Marcin Slusarz [this message]
     [not found]         ` <20120506191456.GE4311-OI9uyE9O0yo@public.gmane.org>
2012-05-06 19:18           ` Marcin Kościelnicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120506191456.GE4311@joi.lan \
    --to=marcin.slusarz-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=koriakin-mP9o5jsk0RY@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.