From: Marcus Karlsson <mk@acc.umu.se>
To: jaseem abid <jaseemabid@gmail.com>
Cc: git mailing list <git@vger.kernel.org>
Subject: Re: Arguments to git hooks
Date: Sun, 6 May 2012 23:11:21 +0200 [thread overview]
Message-ID: <20120506211120.GC5725@moj> (raw)
In-Reply-To: <CAH-tXsBpfXkr-qWdSBhPu6CcSZbm3f=3i1xJVtk6OkHz1NKCfA@mail.gmail.com>
On Mon, May 07, 2012 at 12:48:35AM +0530, jaseem abid wrote:
> On Mon, May 7, 2012 at 12:42 AM, Marcus Karlsson <mk@acc.umu.se> wrote:
> > As far as I can see that's the only argument that git-commit passes on
> > to the commit-msg hook. Can't you just call something like git-status
> > from the hook or do you need the information passed specifically as an
> > argument?
>
> I can always get last commit from `.git/COMMIT_EDITMSG'` - a fixed
> file. Isn't passing that as an argument a bit pointless?
That's a good question. I don't know. If someone else knows the reason I
sure would like to find out.
> I want files I tried to commit specifically passed in as an argument.
There are many different reasons to use hooks. If everything that a hook
could potentially need was passed to it as an argument then a lot of
data would often end up unused. Better to supply as little as possible
and only do more work when it's actually needed.
> Are you suggesting me to run some plumbing command, parse the result
> and get the required data ? Is there an easier way to get this done?
I wouldn't go as deep as the plumbing, I think git status --porcelain
should work just fine, the output is fairly easy to parse.
Marcus
next prev parent reply other threads:[~2012-05-06 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-06 18:35 Arguments to git hooks jaseem abid
2012-05-06 19:12 ` Marcus Karlsson
2012-05-06 19:18 ` jaseem abid
2012-05-06 21:11 ` Marcus Karlsson [this message]
2012-05-06 21:40 ` jaseem abid
2012-05-07 7:21 ` Jeff King
2012-05-07 7:15 ` Jeff King
2012-05-07 22:17 ` Andrew Sayers
2012-05-14 20:34 ` jaseem abid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120506211120.GC5725@moj \
--to=mk@acc.umu.se \
--cc=git@vger.kernel.org \
--cc=jaseemabid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.