From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mmp: add io head file
Date: Mon, 7 May 2012 09:23:07 +0000 [thread overview]
Message-ID: <201205070923.07418.arnd@arndb.de> (raw)
In-Reply-To: <1336360249-29963-2-git-send-email-haojian.zhuang@gmail.com>
On Monday 07 May 2012, Haojian Zhuang wrote:
> +#ifndef __ARCH_MMP_IO_H
> +#define __ARCH_MMP_IO_H
> +
> +#define IO_SPACE_LIMIT 0xffffffff
> +
> +#define __io(a) ((a) & IO_SPACE_LIMIT)
> +
> +#endif
NAK
If you don't have ISA or PCI devices, don't define these.
More importantly, never define them to an incorrect value. This
definition will cause an oops by NULL pointer dereferences for any
access to ISA devices such as writing to /dev/port, or loading a
module that probes the ISA ports.
Arnd
next prev parent reply other threads:[~2012-05-07 9:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 3:10 [PATCH 1/2] mfd: max8925: request resource region Haojian Zhuang
2012-05-07 3:10 ` [PATCH 2/2] ARM: mmp: add io head file Haojian Zhuang
2012-05-07 9:23 ` Arnd Bergmann [this message]
2012-05-07 7:58 ` [PATCH 1/2] mfd: max8925: request resource region Russell King - ARM Linux
2012-05-07 8:18 ` Haojian Zhuang
2012-05-07 8:59 ` Russell King - ARM Linux
2012-05-07 9:01 ` Mark Brown
2012-05-07 9:08 ` Russell King - ARM Linux
2012-05-07 9:47 ` Mark Brown
2012-05-07 10:14 ` Arnd Bergmann
2012-05-07 10:23 ` Haojian Zhuang
2012-05-07 11:21 ` Arnd Bergmann
2012-05-07 11:29 ` Mark Brown
[not found] ` <201205071319.48768.arnd@arndb.de>
2012-05-07 14:02 ` Samuel Ortiz
2012-05-07 14:15 ` Mark Brown
2012-05-07 15:15 ` Arnd Bergmann
2012-05-07 15:28 ` Mark Brown
2012-05-07 10:37 ` Mark Brown
[not found] ` <201205071314.51886.arnd@arndb.de>
2012-05-07 14:06 ` Mark Brown
2012-05-07 15:09 ` Arnd Bergmann
2012-05-07 15:17 ` Mark Brown
2012-05-07 19:26 ` Arnd Bergmann
2012-05-07 19:58 ` Mark Brown
2012-05-08 8:17 ` Mark Brown
2012-05-08 14:44 ` Arnd Bergmann
2012-05-08 15:31 ` Mark Brown
2012-05-09 12:43 ` Arnd Bergmann
2012-05-09 14:13 ` Mark Brown
2012-05-09 14:19 ` Arnd Bergmann
2012-05-09 14:42 ` Mark Brown
2012-05-09 15:03 ` Arnd Bergmann
2012-05-09 15:28 ` Mark Brown
2012-05-09 16:27 ` Arnd Bergmann
2012-05-09 16:18 ` Russell King - ARM Linux
2012-05-09 16:30 ` Mark Brown
2012-05-09 16:07 ` Russell King - ARM Linux
2012-05-09 16:26 ` Arnd Bergmann
2012-05-09 16:27 ` Russell King - ARM Linux
2012-05-07 18:57 ` Russell King - ARM Linux
2012-05-07 19:27 ` Mark Brown
2012-05-07 8:12 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205070923.07418.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.