Re: [PATCH] x86 apic: only compile local function if used

[Ingo Molnar <mingo@kernel.org>]

* Németh Márton <nm127@freemail.hu> wrote:

> From: Márton Németh <nm127@freemail.hu>
> 
> The local function io_apic_level_ack_pending() is only called from
> io_apic_level_ack_pending(). The later function is only compiled
> if CONFIG_GENERIC_PENDING_IRQ is defined. Use this define around
> io_apic_level_ack_pending() function as well.
> 
> This will remove the following warning message during compiling
> without CONFIG_GENERIC_PENDING_IRQ defined:
>  * arch/x86/kernel/apic/io_apic.c:382: warning: ‘io_apic_level_ack_pending’ defined but not used
> 
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index e88300d..9b85009 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -379,6 +379,7 @@ static void __io_apic_modify(unsigned int apic, unsigned int reg, unsigned int v
>  	writel(value, &io_apic->data);
>  }
> 
> +#ifdef CONFIG_GENERIC_PENDING_IRQ
>  static bool io_apic_level_ack_pending(struct irq_cfg *cfg)
>  {
>  	struct irq_pin_list *entry;
> @@ -401,6 +402,7 @@ static bool io_apic_level_ack_pending(struct irq_cfg *cfg)
> 
>  	return false;
>  }
> +#endif
> 
>  union entry_union {
>  	struct { u32 w1, w2; };

it would be better/cleaner to just move this function into the 
already existing #ifdef CONFIG_GENERIC_PENDING_IRQ block.

Thanks,

	Ingo