From: Dan Carpenter <dan.carpenter@oracle.com>
To: nab@linux-iscsi.org
Cc: linux-scsi@vger.kernel.org
Subject: re: qla2xxx: Add LLD target-mode infrastructure for >= 24xx series
Date: Mon, 7 May 2012 16:59:24 +0300 [thread overview]
Message-ID: <20120507135924.GA32419@elgon.mountain> (raw)
Hello Nicholas Bellinger,
This is a semi-automatic email about new static checker warnings.
The patch 2c0532cbbbb5: "qla2xxx: Add LLD target-mode infrastructure
for >= 24xx series" from May 3, 2012, leads to the following Smatch
complaint:
drivers/scsi/qla2xxx/qla_target.c:2965 qlt_abort_task()
error: we previously assumed 'sess' could be null (see line 2958)
drivers/scsi/qla2xxx/qla_target.c
2957 sess = ha->tgt.tgt_ops->find_sess_by_loop_id(vha, loop_id);
2958 if (sess == NULL) {
^^^^^^^^^^^^
New check.
2959 ql_dbg(ql_dbg_tgt_mgt, vha, 0xf025,
2960 "qla_target(%d): task abort for unexisting "
2961 "session\n", vha->vp_idx);
2962 res = qlt_sched_sess_work(ha->tgt.qla_tgt,
2963 QLA_TGT_SESS_WORK_ABORT, iocb, sizeof(*iocb));
2964 if (res != 0)
2965 sess->tgt->tm_to_unknown = 1;
^^^^^^^^^
New dereference.
2966
2967 return res;
regards,
dan carpenter
next reply other threads:[~2012-05-07 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 13:59 Dan Carpenter [this message]
2012-05-07 20:51 ` qla2xxx: Add LLD target-mode infrastructure for >= 24xx series Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2012-03-13 17:20 Dan Carpenter
2012-03-15 23:10 ` Nicholas A. Bellinger
2012-03-16 13:59 ` Jörn Engel
2012-03-17 1:22 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507135924.GA32419@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.