All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] perf/x86-ibs: Add support for IBS pseudo events
Date: Mon, 7 May 2012 17:58:55 +0200	[thread overview]
Message-ID: <20120507155855.GJ18810@erda.amd.com> (raw)
In-Reply-To: <1336405911.27020.70.camel@laptop>

On 07.05.12 17:51:51, Peter Zijlstra wrote:
> On Mon, 2012-05-07 at 17:44 +0200, Robert Richter wrote:
> > On 07.05.12 15:03:02, Peter Zijlstra wrote:
> > > On Wed, 2012-05-02 at 20:26 +0200, Robert Richter wrote:
> > > > +enum ibs_filter_type {
> > > > +       IBS_NO_FILTER           = 0,
> > > > +       IBS_MATCH_FILTER        = 1,
> > > > +       IBS_ANY_SET_FILTER      = 2,
> > > > +       IBS_PSEUDO_EVENT        = 0x0F,
> > > > +};
> > > 
> > > I don't get how those pseudo events work, AFAIKT IBS_PSEUDO_EVENT causes
> > > one to loose all events since it does have a filter set but fails the
> > > filter and thus we skip the call to perf_event_overflow().
> > 
> > You periodically (fix clk cycles or number of micro-ops) trigger IBS
> > samples and afterwards analyses the samples for certain filter rules
> > (see rule description in pmu-ibs.c). 
> 
> But IBS_PSEUDO_EVENT will fail all filter test and you'll end up with
> exactly 0 samples. Still somewhat confused..

Ahh, got your question. This is a place holder for writing the pseudo
event id's (0xF000 mask) directly in config[12]. But this is not yet
implemented. And since we probably all prefer userland filtering we
just don't need this at all.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center


  reply	other threads:[~2012-05-07 15:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 18:26 [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Robert Richter
2012-05-02 18:26 ` [PATCH 1/7] perf tools: Fix generation of pmu list Robert Richter
2012-05-02 18:26 ` [PATCH 2/7] perf tools: Add basic dynamic PMU support Robert Richter
2012-05-02 18:26 ` [PATCH 3/7] perf tools: Add parser for dynamic PMU events Robert Richter
2012-05-07 11:01   ` Peter Zijlstra
2012-05-07 17:05     ` Robert Richter
2012-05-07 17:10       ` Peter Zijlstra
2012-05-02 18:26 ` [PATCH 4/7] perf/x86-ibs: Add support for IBS pseudo events Robert Richter
2012-05-07 11:00   ` Peter Zijlstra
2012-05-07 14:47     ` Robert Richter
2012-05-07 15:15       ` Peter Zijlstra
2012-05-07 16:03         ` Robert Richter
2012-05-07 12:08   ` Peter Zijlstra
2012-05-07 13:03   ` Peter Zijlstra
2012-05-07 15:44     ` Robert Richter
2012-05-07 15:51       ` Peter Zijlstra
2012-05-07 15:58         ` Robert Richter [this message]
2012-05-07 15:21   ` Stephane Eranian
2012-05-07 15:29     ` Peter Zijlstra
2012-05-07 15:52       ` Robert Richter
2012-05-02 18:26 ` [PATCH 5/7] perf, tools: Add raw event support for dynamic allocated pmus Robert Richter
2012-05-07 13:05   ` Peter Zijlstra
2012-05-07 14:20     ` Peter Zijlstra
2012-05-02 18:26 ` [PATCH 6/7] perf tools: Add pmu mappings to header information Robert Richter
2012-05-02 18:26 ` [PATCH 7/7] perf script: Add script to collect and display IBS samples Robert Richter
2012-05-31 15:24 ` [PATCH 0/7] perf/x86-ibs and tools: Add support for AMD IBS Stephane Eranian
2012-05-31 15:51   ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120507155855.GJ18810@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.