Re: [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On Fri, May 04, 2012 at 05:20:19PM -0300, Luiz Capitulino wrote:
> Today, qemu-ga may not be able to emit a success response when
> guest-shutdown completes. This happens because the VM may vanish
> before qemu-ga is able to emit a response.
> 
> This semantic is a bit confusing, as it's not clear for clients if
> they should wait for a response or how they should check for success.
> 
> This commit solves that problem by changing guest-shutdown to never
> emit a success response and suggests in the documentation what
> clients could do to check for success.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qapi-schema-guest.json |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
> index d7a073e..0aa9f91 100644
> --- a/qapi-schema-guest.json
> +++ b/qapi-schema-guest.json
> @@ -131,11 +131,13 @@
>  #
>  # @mode: #optional "halt", "powerdown" (default), or "reboot"
>  #
> -# Returns: Nothing on success
> +# Returns: This command does NOT return a response on success. Success
> +# condition is indicated by the VM exiting with a zero exit status.

Would also include something like:

'or, when running with --no-shutdown, by running the query-status QMP
command to confirm the status/RunState is "shutdown"'

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

>  #
>  # Since: 0.15.0
>  ##
> -{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' } }
> +{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' },
> +  'success-response': 'no' }
> 
>  ##
>  # @guest-file-open:
> -- 
> 1.7.9.2.384.g4a92a
>