All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: JBottomley@parallels.com, joerg@alea.gnuu.de,
	linux-kernel@vger.kernel.org
Subject: Re: Regression introduced by 6f381fa344911d5a234b13574433cf23036f9467 [[SCSI] scsi_lib: use correct DMA device in __scsi_alloc_queue]
Date: Mon, 7 May 2012 13:50:39 -0400	[thread overview]
Message-ID: <20120507175039.GA6423@phenom.dumpdata.com> (raw)
In-Reply-To: <CAF1ivSZNH3R-U=d=yBW4m9PO8TQSbSP=dHR3okdsO7EkOm2RMQ@mail.gmail.com>

> > reverting above mentioned git commit fixes the issue.
> 
> Does Jame's below patch help?
> 
> http://www.spinics.net/lists/linux-scsi/msg59106.html

Yes.  please add Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
on the latter part of that patch:


diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 351dc0b..a3a056a 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -218,6 +218,9 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
 
 	if (!shost->shost_gendev.parent)
 		shost->shost_gendev.parent = dev ? dev : &platform_bus;
+	if (!dma_dev)
+		dma_dev = shost->shost_gendev.parent;
+
 	shost->dma_dev = dma_dev;
 
 	error = device_add(&shost->shost_gendev);

  reply	other threads:[~2012-05-07 17:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 13:52 Regression introduced by 6f381fa344911d5a234b13574433cf23036f9467 [[SCSI] scsi_lib: use correct DMA device in __scsi_alloc_queue] Konrad Rzeszutek Wilk
2012-05-07 14:57 ` Lin Ming
2012-05-07 17:50   ` Konrad Rzeszutek Wilk [this message]
2012-05-07 18:36     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120507175039.GA6423@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBottomley@parallels.com \
    --cc=joerg@alea.gnuu.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.